Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/nodowncast2 #339

Merged
merged 6 commits into from
Mar 31, 2014
Merged

Fix/nodowncast2 #339

merged 6 commits into from
Mar 31, 2014

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Mar 20, 2014

In progress, for those who want to follow along.

Closes: #330

@mr-c mr-c added this to the 1.0 release milestone Mar 20, 2014
@mr-c
Copy link
Contributor Author

mr-c commented Mar 25, 2014

The commit 886fe8a may explain/fix #266.

@mr-c
Copy link
Contributor Author

mr-c commented Mar 25, 2014

I am handing this off to @luizirber to wrap this up, thanks again!

@mr-c
Copy link
Contributor Author

mr-c commented Mar 31, 2014

test this please

1 similar comment
@mr-c
Copy link
Contributor Author

mr-c commented Mar 31, 2014

test this please

@ged-jenkins
Copy link

Test FAILed.
Refer to this link for build results: http://ci.ged.msu.edu/job/khmer-multi-pullrequest/403/

@ged-jenkins
Copy link

Test FAILed.
Refer to this link for build results: http://ci.ged.msu.edu/job/khmer-multi-pullrequest/405/

@mr-c
Copy link
Contributor Author

mr-c commented Mar 31, 2014

test this please

@ged-jenkins
Copy link

Test FAILed.
Refer to this link for build results: http://ci.ged.msu.edu/job/khmer-multi-pullrequest/407/

@mr-c
Copy link
Contributor Author

mr-c commented Mar 31, 2014

retest this please

@ged-jenkins
Copy link

Test PASSed.
Refer to this link for build results: http://ci.ged.msu.edu/job/khmer-multi-pullrequest/408/

@ged-jenkins
Copy link

Test FAILed.
Refer to this link for build results: http://ci.ged.msu.edu/job/khmer-multi-pullrequest/409/

@ged-jenkins
Copy link

Test PASSed.
Refer to this link for build results: http://ci.ged.msu.edu/job/khmer-multi-pullrequest/412/

@ged-jenkins
Copy link

Test FAILed.
Refer to this link for build results: http://ci.ged.msu.edu/job/khmer-multi-pullrequest/413/

@ged-jenkins
Copy link

Test FAILed.
Refer to this link for build results: http://ci.ged.msu.edu/job/khmer-multi-pullrequest/414/

@ged-jenkins
Copy link

Test FAILed.
Refer to this link for build results: http://ci.ged.msu.edu/job/khmer-multi-pullrequest/415/

@mr-c
Copy link
Contributor Author

mr-c commented Mar 31, 2014

  • Is it mergable
  • Did it pass the tests?
  • N/A If it introduce new functionality in scripts/ is it tested?
    Check for code coverage.
  • Is it well formatted? Look at pep8/pylint, cppcheck, and
    make doc output. Use autopep8 and astyle -A10 if needed.
  • Is it documented in the Changelog?

@mr-c
Copy link
Contributor Author

mr-c commented Mar 31, 2014

retest this please

@ged-jenkins
Copy link

Test PASSed.
Refer to this link for build results: http://ci.ged.msu.edu/job/khmer-multi-pullrequest/416/

mr-c added a commit that referenced this pull request Mar 31, 2014
@mr-c
Merge pull request #339 from ged-lab/fix/nodowncast2
cfcc566 
Fix/nodowncast2
@mr-c mr-c merged commit cfcc566 into master Mar 31, 2014
@mr-c mr-c deleted the fix/nodowncast2 branch March 31, 2014 22:23
mr-c added a commit that referenced this pull request Apr 1, 2014
@mr-c
Merge pull request #339 from ged-lab/fix/nodowncast2
a516caa 
Fix/nodowncast2
mr-c added a commit that referenced this pull request Apr 2, 2014
@mr-c
Merge pull request #339 from ged-lab/fix/nodowncast2
303f852 
Fix/nodowncast2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@luizirber luizirber

Labels
None yet
Projects
None yet
Milestone
1.0 release
Development

Successfully merging this pull request may close these issues.

finish fixing implicit downcasts
3 participants
@mr-c @ged-jenkins @luizirber