added test for #361, indent problem in script #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ref issue #361 |
|
@mr-c could you take a look at this? I think it's good but I did the last set of pushes so it should be reviewed by someone else. TIA! |
| @@ -1,3 +1,6 @@ | |||
| 2014-09-22 Sherine Awad <sherine.awad@gmail.com> | |||
There was a problem hiding this comment.
Two spaces between the date and your name and your name and your email address please.
|
| args = ['--loadtable', hashfile, infile] | ||
| (status, out, err) = utils.runscript(script, args) | ||
| assert status == 0, (out, err) | ||
| print (out, err) |
There was a problem hiding this comment.
FYI: The print statement isn't technically needed as the (out, err) will be presented if the assertion fails. Not a problem, though
There was a problem hiding this comment.
Nevermind, this does help quite a lot with debugging given the line squashing that Nose does
|
I verified this by re-introducing the indent error in 3d79783 this test (and only this test) does indeed catch it. LGTM. Merge once the ChangeLog formatting is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also see #608, a contaminated pull request that we are replacing.