Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post merge cleanup of #749 #765

Merged
merged 6 commits into from Feb 11, 2015
Merged

post merge cleanup of #749 #765

merged 6 commits into from Feb 11, 2015

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Feb 11, 2015

No description provided.

@mr-c
Copy link
Contributor Author

mr-c commented Feb 11, 2015

#749 (comment) still needs addressing

@ctb
Copy link
Member

ctb commented Feb 11, 2015

whistles nonchalantly nothing to see here. Ready for review.

@mr-c
Copy link
Contributor Author

mr-c commented Feb 11, 2015

Testing FTW :-)

  • Is it mergable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@ctb
Copy link
Member

ctb commented Feb 11, 2015

hang on a bit, fixing something else.

@ctb
Copy link
Member

ctb commented Feb 11, 2015

test this please

@ctb
Copy link
Member

ctb commented Feb 11, 2015

Ready for review.

@ctb
Copy link
Member

ctb commented Feb 11, 2015

Actually, now I'm confused. You made some changes, I made some changes... who should review? :)

@mr-c
Copy link
Contributor Author

mr-c commented Feb 11, 2015

:-) This PR is all you. LGTM; merging

mr-c added a commit that referenced this pull request Feb 11, 2015
@mr-c mr-c merged commit b71158b into master Feb 11, 2015
@mr-c mr-c deleted the feature/tag_with_position branch February 11, 2015 16:13
@ctb
Copy link
Member

ctb commented Feb 11, 2015

Excellent. (I knew I could slide stuff by you by changing hash to counting and hashbits to presence :)

@mr-c
Copy link
Contributor Author

mr-c commented Feb 11, 2015

You know me well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants