Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point we configured
asv
to run benchmarks, but it was never integrated into CI (or had many benchmarks implemented). Working on improving the situation =]This is a start, making
asv
run without dependencies ontests/
. It would be better to have a fixed set of data in every run (even thought is unlikely that the random data will be extremely biased for one specific comparison in the benchmarks), but maybe do that in #128.I also added the first github action to the repo. This way we don't extend our running time on Travis. The benchmark check is not required (for now), but it is nice to have some performance tracking that doesn't required running
asv
locally or depending on PR submitter self-reporting.Checklist
make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?