Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix asv benchmarks #509

Merged
merged 4 commits into from Oct 21, 2019
Merged

Fix asv benchmarks #509

merged 4 commits into from Oct 21, 2019

Conversation

luizirber
Copy link
Member

@luizirber luizirber commented Jun 28, 2018

At some point we configured asv to run benchmarks, but it was never integrated into CI (or had many benchmarks implemented). Working on improving the situation =]

This is a start, making asv run without dependencies on tests/. It would be better to have a fixed set of data in every run (even thought is unlikely that the random data will be extremely biased for one specific comparison in the benchmarks), but maybe do that in #128.

I also added the first github action to the repo. This way we don't extend our running time on Travis. The benchmark check is not required (for now), but it is nice to have some performance tracking that doesn't required running asv locally or depending on PR submitter self-reporting.

Checklist

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov-io
Copy link

codecov-io commented Jun 28, 2018

Codecov Report

Merging #509 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #509   +/-   ##
=======================================
  Coverage   88.59%   88.59%           
=======================================
  Files          30       30           
  Lines        4727     4727           
  Branches       46       46           
=======================================
  Hits         4188     4188           
  Misses        536      536           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 926a22c...4740898. Read the comment docs.

@luizirber luizirber force-pushed the bench/fixes branch 5 times, most recently from 7521144 to 0c1ef25 Compare October 17, 2019 04:16
@luizirber luizirber changed the title [WIP] Fix asv benchmarks Fix asv benchmarks Oct 17, 2019
@luizirber
Copy link
Member Author

Ready for review and merge @ctb @olgabot

@luizirber luizirber requested a review from ctb October 17, 2019 23:41
Copy link
Contributor

@ctb ctb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ctb ctb merged commit ee195b4 into master Oct 21, 2019
@ctb ctb deleted the bench/fixes branch October 21, 2019 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants