Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[small] and [large] tags stack with and negate each other #43

Closed
Dibasic opened this issue Mar 15, 2019 · 2 comments
Closed

[small] and [large] tags stack with and negate each other #43

Dibasic opened this issue Mar 15, 2019 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@Dibasic
Copy link
Owner

Dibasic commented Mar 15, 2019

Describe the bug
Each nested [small] or [large] tag continues to decrease or increase the size of text. This can result in very small or very large text or nested opposite tags cancelling each other out.

To Reproduce
Steps to reproduce the behavior:

  1. Enter the example code below into the input textarea.

Expected behavior

  • Only one level of [small] and [large] should be possible. There should be no difference between [small]X[/small] and [small][small]X[/small][/small].
  • [small] and [large] tags should not negate each other. Instead, text should be the size set by the first tag it's in (text in a large tag should be large, even if that large tag is inside a small tag)

Web Browser (please complete the following information):

  • Firefox, Edge
  • Latest versions

Screenshots
Ingame:
image
image
Simulator:
image
image

Pen Code
TEST1[small]TEST2[small]TEST3[small]TEST4[/small][/small][/small]
TEST1[small]TEST2[large]TEST3[/large]TEST4[/small]TEST5

Additional context
We are using <small> and <large> tags, while the game uses <font>. Fixing this may require some snowflakey checks.

@Dibasic Dibasic added bug Something isn't working help wanted Extra attention is needed labels Mar 15, 2019
@soryy708
Copy link
Contributor

soryy708 commented Mar 15, 2019

Nah. Just have the font size change to an absolute one, not a relative one.

Instead of turning [small] in to <small>, turn it in to <span class="small-text"> where small-text will have font-size of, say, 12px or something absolute. Same for [large]

@soryy708
Copy link
Contributor

#46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants