Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify index2 naming in config #56

Closed
2 tasks done
yamalight opened this issue Oct 11, 2017 · 6 comments
Closed
2 tasks done

Clarify index2 naming in config #56

yamalight opened this issue Oct 11, 2017 · 6 comments

Comments

@yamalight
Copy link
Member

yamalight commented Oct 11, 2017

Currently in config we have two following fields:

index=index
index2=index_bycontext

From name it is not clear what is index2 and how it's used.
I'd suggest doing the following:

  • (short term) add comment to config file clarifying what it does
  • (long term) rename it to reflect its role
@DiegoMoussallem
Copy link
Member

improved with the new commit.

@yamalight
Copy link
Member Author

yamalight commented Feb 19, 2018

@DiegoMoussallem looks like this broke tests: https://gitlab.com/aksw/AGDISTIS/-/jobs/53308720
please fix them

@DiegoMoussallem
Copy link
Member

I thought the problem was the one pointed by Ricardo above then I fixed it which was from indextest to index again in property files. But the error still appears. Do you have any tip @yamalight ? because If you download the code e run by maven it works and delivers the same results expected by test-docker.sh.

@DiegoMoussallem
Copy link
Member

Seems that https://gitlab.com/aksw/AGDISTIS/commits/master takes time to mirror the commits. lets see

@DiegoMoussallem
Copy link
Member

everything is ok now

@yamalight
Copy link
Member Author

looks good, thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants