Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for bodyguard qty and bodyguards not spawning #15

Open
WuphonsReach opened this issue Jan 4, 2021 · 1 comment
Open

Bug fixes for bodyguard qty and bodyguards not spawning #15

WuphonsReach opened this issue Jan 4, 2021 · 1 comment

Comments

@WuphonsReach
Copy link

WuphonsReach commented Jan 4, 2021

Bodyguard script does not look like it paid attention to the leadership skill. Looking at all of the other uses of getting the player's leadership value, they all pass that in as a string and not a variable name.

WuphonsReach@1b8d274

When attempting to infiltrate a castle, I was spotted and then the guards beat me down and captured me. This resulted in the $g_mt_mode flag being stuck "on" (i.e. I was permanently flagged as disguised). My suggestion for fixing this is that whenever the player gets captured, we set the flag back to the default. (Later, I got myself captured again and it cleared the stuck flag as expected.)

WuphonsReach@841e62a

(These commits are all on my "beggars-1" branch.)

@WuphonsReach
Copy link
Author

WuphonsReach commented Jan 6, 2021

More details on "why bodyguards fail to spawn" (and why WuphonsReach@841e62a may not be the best fix)

There are other lines of code in the scripts that call (assign, "$g_mt_mode" and assign values of 1. In particular:

  • abm_training
  • ctm_melee
  • vba_normal - which gets set when you enter a village infested with bandits (a common one for players to run into)

It looks like very few of those then set the global variable back to value zero. I'm wondering if setting tcm_disguised to a more unique value like 99 would break things or help fix things.

Update: Changing to 99 seems to cause no ill effects and definitely makes the bodyguards spawn as expected.

@WuphonsReach WuphonsReach changed the title Bug fixes for bodyguards and infiltration disguise getting stuck Bug fixes for bodyguard qty and bodyguards not spawning Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant