-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR for #247: Submit to AER #249
Conversation
I'm on it @santiagohermo! I'll create a draft of the release so you can check if it's ok. |
Draft of the release here @santiagohermo |
Everything seems good with the changes @santiagohermo! We didn't need a cover letter for the AER did we? |
Gracias @martingallardo23!
Recibí una notificación de que el paper fue "unsubmitted" porque estaban mal los disclosure statements. Los mejoré en fbc585a. La disclosure policy está en https://www.aeaweb.org/journals/policies/disclosure-policy. Hay ejemplos en https://www.aeaweb.org/journals/policies/disclosure-policy/disclosure-examples. Te fijás rápido que estos PDFs estén de acuerdo con la policy? La parte relevante del mail que me enviaron:
|
Btw, cuando termines con el review podés ir a "Files changed", "Review" y marcar "Approved" @martingallardo23? Creo que rinde usar las herramientas que nos provee el gran GitHub :D |
One note @martingallardo23. @gabrieleborg confirmed that the revised disclosure statements look good, so I completed the submission. Thanks @gabrieleborg! A new confirmation is confirmation_submission_aer_2.pdf I will now proceed to wrap up this issue. |
Publiqué la release sin querer @martingallardo23, así que la tuve que crear de nuevo :/ |
Paper has been submitted to the AER! See #247 (comment).
Steps for this PR:
AER1
. We should upload the version of the pdf in this branch, and link public-draft for the data snapshots (which haven't changed).Can you help @gabrieleborg @martingallardo23?