Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for #247: Submit to AER #249

Merged
merged 8 commits into from
Aug 23, 2022
Merged

PR for #247: Submit to AER #249

merged 8 commits into from
Aug 23, 2022

Conversation

santiagohermo
Copy link
Collaborator

Paper has been submitted to the AER! See #247 (comment).

Steps for this PR:

  • Create a release with the name AER1. We should upload the version of the pdf in this branch, and link public-draft for the data snapshots (which haven't changed).
  • Quickly review changes in this branch.

Can you help @gabrieleborg @martingallardo23?

@martingallardo23
Copy link
Collaborator

I'm on it @santiagohermo! I'll create a draft of the release so you can check if it's ok.

@martingallardo23
Copy link
Collaborator

Draft of the release here @santiagohermo

@martingallardo23
Copy link
Collaborator

Everything seems good with the changes @santiagohermo! We didn't need a cover letter for the AER did we?

@santiagohermo santiagohermo removed the request for review from gabrieleborg August 22, 2022 14:06
@santiagohermo santiagohermo self-assigned this Aug 22, 2022
@santiagohermo
Copy link
Collaborator Author

Gracias @martingallardo23!

  • Metí algunos cambios en el draft del release. Ya está para salir! Apenas meta S&M acá la publico, así el tag AER1 apunta a la versión correcta de master.
  • Gracias por el review del código! El cover letter era opcional, así que decidí no incluir nada. Fijate la sección "Cover letter:" abajo de "Please note:" acá

Recibí una notificación de que el paper fue "unsubmitted" porque estaban mal los disclosure statements. Los mejoré en fbc585a.

La disclosure policy está en https://www.aeaweb.org/journals/policies/disclosure-policy. Hay ejemplos en https://www.aeaweb.org/journals/policies/disclosure-policy/disclosure-examples. Te fijás rápido que estos PDFs estén de acuerdo con la policy?

La parte relevante del mail que me enviaron:

Your manuscript, AER-2022-1098, "Minimum Wage as a Place-Based Policy: Evidence from US Housing Rental Markets," has been unsubmitted by the American Economic Review editorial office.

The AER has instituted a policy whereby manuscripts that do not conform to our Submission Guidelines will not be sent out for review.

Each author needs to be represented by a separate disclosure statement, specific to the submitted paper.

Please include your full name(s) and the title of your paper on the Disclosure Statement PDF(s).

@santiagohermo
Copy link
Collaborator Author

Btw, cuando termines con el review podés ir a "Files changed", "Review" y marcar "Approved" @martingallardo23? Creo que rinde usar las herramientas que nos provee el gran GitHub :D

@santiagohermo
Copy link
Collaborator Author

One note @martingallardo23. @gabrieleborg confirmed that the revised disclosure statements look good, so I completed the submission. Thanks @gabrieleborg!

A new confirmation is confirmation_submission_aer_2.pdf

I will now proceed to wrap up this issue.

@santiagohermo
Copy link
Collaborator Author

Publiqué la release sin querer @martingallardo23, así que la tuve que crear de nuevo :/

@santiagohermo santiagohermo merged commit 5eb3690 into master Aug 23, 2022
@santiagohermo santiagohermo deleted the issue247_AERsubmission branch August 23, 2022 14:40
@santiagohermo
Copy link
Collaborator Author

Summary here. Relevant release is AER1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants