New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Yoga to 3.0 #2692

Open

wojtekmaj opened this issue Mar 27, 2024 · 1 comment · May be fixed by #2711

Labels

Contributor

wojtekmaj commented Mar 27, 2024 •

edited

Updating Yoga to 3.0 will bring several features into React-PDF:

Support for position: static
Support for align-content: space-evenly
Improvements to layout correctness
Yoga’s JavaScript bindings are now distributed as an ES Module
Fixes several crashes in Java bindings
Some existing Yoga APIs have been removed

Source: https://www.yogalayout.dev/blog/announcing-yoga-3.0

But also, it will:

Resolve [solution] __dirname is not defined in ES module scope #2507, bringing in true, zero configuration ESM compatibility

Potential breaking changes:

Yoga 3.0 is distributed as ESM-only. We might be forced to make React-PDF ESM-only as well.
Given that there are "layout correctness" improvements makes me believe this should be considered a breaking change, as people may have used certain workarounds that would stop working after an update.

wojtekmaj added the new feature label

Owner

diegomura commented Mar 27, 2024

Nice! Excited to see this in place. Will try to find some time to work on it soon, but if anyone has time please be my guest 😄

wojtekmaj added a commit to wojtekmaj/diegomura-react-pdf that referenced this issue


          feat!: update Yoga to 3.0

4d429fe

Closes diegomura#2692
Closes diegomura#2507

This PR updates Yoga to 3.0.

See the list of new features, improvements, and potential breaking changes in diegomura#2692.

wojtekmaj linked a pull request

that will close this issue

feat!: update Yoga to 3.0 #2711

Draft

wojtekmaj added a commit to wojtekmaj/diegomura-react-pdf that referenced this issue


          feat!: update Yoga to 3.0

862e2cc

Closes diegomura#2692
Closes diegomura#2507

This PR updates Yoga to 3.0.

See the list of new features, improvements, and potential breaking changes in diegomura#2692.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment