feat: wasm yoga #2505
Merged
feat: wasm yoga #2505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 035e56f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
diegomura
force-pushed
the
dm/wasm-yoga
branch
from
188bfa8
to
bc80f88
Compare
|
From my ESM stuff perspective, that looks alright :D |
diegomura
force-pushed
the
dm/wasm-yoga
branch
from
bc80f88
to
5892129
Compare
diegomura
force-pushed
the
dm/wasm-yoga
branch
from
5892129
to
035e56f
Compare
mskec
pushed a commit
to mskec/react-pdf
that referenced
this pull request
Feb 26, 2024
|
This seems to have caused the following issue: #2589 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
loadYogafromyoga-layoutmain entrypoint to leverage wasm internal usage.This is supposed to ship less code and also be more performant. In tests I couldn't see much of a difference to be honest, but it's cool we run flex engine in wasm code as it's supposed to be more performant. Maybe in larger documents will be more noticeable. It does not introduce breaking changes as layout process is already async
I'd appreciate some thoughts about this :) cc/ @wojtekmaj @jeetiss