Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CI workflow error #2631

Merged
merged 1 commit into from
Feb 11, 2024
Merged

fix: CI workflow error #2631

merged 1 commit into from
Feb 11, 2024

Conversation

wojtekmaj
Copy link
Contributor

@wojtekmaj wojtekmaj commented Feb 10, 2024

Fixes an issue where .toUpperCase() was used in an expression that's not JS, causing an error.

Please kindly run this workflow against this branch - no other way to test it, and I can't trigger it myself.

Copy link

changeset-bot bot commented Feb 10, 2024

⚠️ No Changeset found

Latest commit: 6ef054d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Owner

@diegomura diegomura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Couldn't find a way to run it 😅 But change looks good. Let's get it in and see from there

@diegomura diegomura changed the title fix: fix CI workflow error fix: CI workflow error Feb 11, 2024
@diegomura diegomura merged commit 9093e62 into diegomura:master Feb 11, 2024
@wojtekmaj wojtekmaj deleted the fix-ci branch February 11, 2024 17:03
@wojtekmaj
Copy link
Contributor Author

wojtekmaj commented Feb 11, 2024

I think we're getting there but it might be one more issue: ternary being used.

Let's try with cond && when_true || when_false maybe?

https://docs.github.com/en/actions/learn-github-actions/expressions#example

I can give it another go but in two hours, maybe a bit more. Feel free to try it out in the meantime!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants