fix: bump jay-peg dependency to fix CJS module resolution error #2635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jay-peg 1.0.0 suffered from an issue that caused module resolution error in CJS mode.
🦋 Changeset detectedLatest commit: f2f745b The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wojtekmaj
added a commit
to wojtekmaj/diegomura-react-pdf
that referenced
this pull request
Feb 12, 2024
Turns out, generated PDFs differ slightly from platform to platform. As the previous reference file I generated comes from macOS, it fails when E2E is ran on linux. This fixes that by introducing platform-specific reference files. Note: without diegomura#2633, E2E will error, and without diegomura#2635, CJS E2E will still fail.
|
Thanks! Forgot to bump it 🤦🏻 |
wojtekmaj
added a commit
to wojtekmaj/diegomura-react-pdf
that referenced
this pull request
Feb 12, 2024
Turns out, generated PDFs differ slightly from platform to platform. As the previous reference file I generated comes from macOS, it fails when E2E is ran on linux. This fixes that by introducing platform-specific reference files. Note: without diegomura#2633, E2E will error, and without diegomura#2635, CJS E2E will still fail.
mskec
pushed a commit
to mskec/react-pdf
that referenced
this pull request
Feb 26, 2024
…omura#2635) jay-peg 1.0.0 suffered from an issue that caused module resolution error in CJS mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jay-peg 1.0.0 suffered from an issue that caused module resolution error in CJS mode.