Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activating Open Collective #93

Merged
merged 7 commits into from
Jun 13, 2017

Conversation

xdamman
Copy link
Contributor

@xdamman xdamman commented Jun 5, 2017

This pull request adds backers and sponsors from your Open Collective https://opencollective.com/react-pdf ❤️

It adds two badges at the top to show the latest number of backers and sponsors. It also adds placeholders so that the avatar/logo of new backers/sponsors can automatically be shown without having to update your README.md. [more info]. See how it looks on this repo.
We have also added a postinstall script to let people know after npm|yarn install that you are welcoming donations (optional). [More info]

You can also add a "Donate" button to your website and automatically show your backers and sponsors there with our widgets. Have a look here: https://opencollective.com/widgets

P.S: As with any pull request, feel free to comment or suggest changes. The only thing "required" are the placeholders on the README because we believe it's important to acknowledge the people in your community that are contributing (financially or with code!).

Thank you for your great contribution to the open source community. You are awesome! 🙌
And welcome to the open collective community! 😊

Come chat with us in the #opensource channel on https://slack.opencollective.com - great place to ask questions and share best practices with other open source sustainers!

@xdamman
Copy link
Contributor Author

xdamman commented Jun 5, 2017

This is the error on travis-ci, not sure if I need to do anything:
error Your lockfile needs to be updated, but yarn was run with "--frozen-lockfile".

@diegomura
Copy link
Owner

Thanks @xdamman !
Don't worry about travis, I'll fix it.
As placeholders do you mean both backers and sponsors ? Is it possible to add only backers for the moment?

@xdamman
Copy link
Contributor Author

xdamman commented Jun 6, 2017

Yes it's possible to only have backers. We would just need to remove the "sponsors" tier on your collective. Is that what you want to do? Out of curiosity, what's the reason?

@diegomura
Copy link
Owner

Thanks @xdamman .
Not a strong argument about why not including sponsors. I just prefer starting just with backers, and see if people are willing to contribute, which I'm still not sure if will. I plan adding it in the future if this works.
I'll submit that change and maybe some more to this PR very soon. Thanks!

Repository owner deleted a comment from parham2 Jun 8, 2017
Repository owner deleted a comment from parham2 Jun 8, 2017
@xdamman
Copy link
Contributor Author

xdamman commented Jun 9, 2017

I've removed the "sponsors" tier on your collective https://opencollective.com/react-pdf

@diegomura
Copy link
Owner

@xdamman I'll merge when I get your approval 😄

@xdamman
Copy link
Contributor Author

xdamman commented Jun 13, 2017

Approved ;-)

But why not keeping the "backers" badge?

@diegomura
Copy link
Owner

diegomura commented Jun 13, 2017

I dont want that to be the only one there. I'll add some badges in the future, that included i think. I didnt has that much time these days. Thanks for your approval!

@diegomura diegomura merged commit b2370f1 into diegomura:master Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants