Weeks does not start with Sunday in Turkish

[ghost]

In Turkish and some other countries, the first day of the week is Monday (meaning Pazartesi).

GNOME Calendar uses the correct format for this.

On the other hand, Dosage starts the week from Monday.

You may check the following article for more information: https://www.timeanddate.com/calendar/days/

[diegopvlk]

Can you test it?

[ghost]

Thanks. Fixed.

[diegopvlk]

Is this still working? When I run with the LC_ALL=tr_TR I still get Sunday as the first day

[ghost]

Seems broken now.

[diegopvlk]

Yeah, I have no idea how to reliably get the first day of the week. If you know how, please let me know.

[ghost]

I see two examples that seems the same or similar.

https://gitlab.gnome.org/GNOME/gnome-calendar/-/blob/main/src/utils/gcal-utils.c?ref_type=heads#L330-387

https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/src/shell-util.c?ref_type=heads#L79-135

[ghost]

From Evolution

[diegopvlk]

I understand very little of this code. The calculation seems to be correct (I think..)

The problem is figuring it out the week number of the current locale (I'm using 1, October 2000) this day for me is on week 40, for you it should be week 39.

It's always gives 40 as the result now, before it gave 39 when I changed the locale, I didn't change anything in the code and somehow it stopped working so ¯_(ツ)_/¯

[ghost]

Could you use different date. E.g: 1, October 2017. Turkish timezone and daylight saving changed around 2016.

[erklyn]

I could try to tackle this.

[diegopvlk]

Could you use different date. E.g: 1, October 2017. Turkish timezone and daylight saving changed around 2016.

Doesn't seem to make a difference.

I could try to tackle this.

@erklyn That's the function:

Dosage/src/utils.js

Lines 15 to 24 in 66b505d

	function weekStartsMonday() {
	const date = new Date(2000, 9, 0);
	const startOfYear = new Date(2000, 0, 1);
	const dayOfYear = Math.floor((date - startOfYear) / 86400000) + 1;
	const weekNumber = Math.ceil(dayOfYear / 7);
	// 39 = starts on monday
	// 40 = starts on sunday
	return weekNumber === 39;
	}

If you manage to fix it, please open a PR.

Also make sure to backup your data before running the latest commit, I change some stuff and I didn't test everything properly yet, so it may cause some data loss.

[erklyn]

@diegopvlk looks fine and works fine on my system as well, returns 39 for me I am an in Turkey so works correctly.

there might be an issue on the button part. I'll take a look as soon as possible and post a pr.

[diegopvlk]

@erklyn It's not the button, you can test it by just returning false instead.

What's your output of locale?

[diegopvlk]

Turns out there is a very simple command to check the first weekday: locale first_weekday 🤦‍♂️