Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow importing public tables #17

Closed
pdobacz opened this issue Sep 28, 2022 · 4 comments · Fixed by #34
Closed

Allow importing public tables #17

pdobacz opened this issue Sep 28, 2022 · 4 comments · Fixed by #34
Assignees

Comments

@pdobacz
Copy link
Collaborator

pdobacz commented Sep 28, 2022

c.f. #7 (comment)

@pdobacz pdobacz self-assigned this Oct 6, 2022
@pdobacz
Copy link
Collaborator Author

pdobacz commented Oct 6, 2022

Not without hesitation, but I'd propose to keep this minimal - if in the AID selection step no AID is selected, then the table is imported as public.

We display a ⚠️ with a suitable text, that data in this table will not be anonymized etc. I want the warning displayed where the import is happening (possibly in the same text area, where the name-conflict warning will appear). This UX-overlap with the name-conflict is the reason why I owned this issue as well - just to have both warnings get the same feel.

While doing so, I'll also rework the wording of the choice of "RowIndex" AID, which is currently called "None", which will not be right. I think it should now say "Auto-generated row index column" (wording pending) + a suitable explanation in the textbox

@cristianberneanu
Copy link
Contributor

if in the AID selection step no AID is selected, then the table is imported as public.

We could add an extra option to the AID select input, called "Non-personal data". That way, we can force the user to make an explicit choice each time. Or add a checkbox above the select input called "Personal data". If unchecked, the AID select input gets disabled.

@pdobacz
Copy link
Collaborator Author

pdobacz commented Oct 6, 2022

yeah, so that was my hesitation about. If we want to force the user to stop at that point, then yeah, explicit choice is better, but do we want to force? Hard to guess now. I'm slightly more for a warning+less clicks, but I have no strong opinion.

This way or another - I think we should set the default to be "Personal data", so the checkbox checked. I'm guessing majority of the data will be flat tables, so public data imports will not be that often made (or re-made)

@cristianberneanu
Copy link
Contributor

cristianberneanu commented Oct 6, 2022

I think we want to force the user to stop and think about the imported data at that point. From what I remember, Paul explicitly wanted it like this for Desktop, so it makes sense to have it likewise for Dashboards.

I think we should set the default to be "Personal data", so the checkbox checked.

Yes, that was my thought as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants