Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SnapshotValueReader #4

Merged
merged 16 commits into from
Aug 23, 2023
Merged

Implement SnapshotValueReader #4

merged 16 commits into from
Aug 23, 2023

Commits on Aug 11, 2023

  1. First step towards implementing SnapshotValueReader.

    @nedtwigg
    nedtwigg committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    480bc97 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2023

  1. Add more test cases.

    @nedtwigg
    nedtwigg committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    21b242d View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Merge branch 'main' into feat/snapshot-value-reader

    @nedtwigg
    nedtwigg committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    78d2a7b View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. SnapshotValueReader: implement peek/next value 

    - Use a `line` as buffer for doing peek
- Uncomment tests
    @jknack
    jknack committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    48adb00 View commit details
    Browse the repository at this point in the history

  2. kmm: make js of LineReader.readLine nullable

    @jknack
    jknack committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    692ac51 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Workaround the Kotlin bug so that we don't have to use experimental K… 

    …2 anymore, IDE test should be much more stable now.
    @nedtwigg
    nedtwigg committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    b3a5ac5 View commit details
    Browse the repository at this point in the history

  2. Introduce ParseException.

    @nedtwigg
    nedtwigg committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    b334f07 View commit details
    Browse the repository at this point in the history

  3. Use unescape when parsing, and escape when serializing.

    @nedtwigg
    nedtwigg committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    1e229d2 View commit details
    Browse the repository at this point in the history

  4. Carefully adjust the assertions in SnapshotValueReaderTest.

    @nedtwigg
    nedtwigg committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    bb0e786 View commit details
    Browse the repository at this point in the history

  5. Add a failing testSkip test.

    @nedtwigg
    nedtwigg committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    58dceba View commit details
    Browse the repository at this point in the history

  6. Add tests for leading and trailing whitespace within single-line snap… 

    …shots.
    @nedtwigg
    nedtwigg committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    62b67eb View commit details
    Browse the repository at this point in the history

  7. Rename test to skipValues.

    @nedtwigg
    nedtwigg committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    f50d129 View commit details
    Browse the repository at this point in the history

  8. tests: fix almost all offending tests 

    - fix failing tests
- refactor scanValue lookup
- implement skipValues
- make sure spaces/lines are keep
- TODO: unclear the body escape function
    @jknack
    jknack committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    cc0b2ec View commit details
    Browse the repository at this point in the history

  9. Fix escaping of ╔ when it's the first character of a line within a … 

    …value.
    @nedtwigg
    nedtwigg committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    2f3ac1a View commit details
    Browse the repository at this point in the history

  10. Minor refactor using Kotlin idioms like inline fun.

    @nedtwigg
    nedtwigg committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    f4a3fe7 View commit details
    Browse the repository at this point in the history

  11. Oops, FastMap got renamed to ArrayMap but that didn't make it into th… 

    …e multiplatform files.
    @nedtwigg
    nedtwigg committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    c878cc2 View commit details
    Browse the repository at this point in the history