-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement SnapshotValueReader
#4
Conversation
@nedtwigg should I merge this? or work in the feature branch? |
Work in this feature branch |
- Use a `line` as buffer for doing peek - Uncomment tests
2274a92
to
48adb00
Compare
@nedtwigg here is. I took me a bit I have to learn/read a bit about KMM and also struggling with IDEA to run tests. Make |
Looks great at first glance! I'll take a look later tonight and then point you at the next task on this project. |
…2 anymore, IDE test should be much more stable now.
@jknack an excellent start! I did a few things in the commits above:
My advice is:
|
@nedtwigg pushed a new commit. I left one question about body escape |
- fix failing tests - refactor scanValue lookup - implement skipValues - make sure spaces/lines are keep - TODO: unclear the body escape function
e6848e4
to
cc0b2ec
Compare
Excellent, you did the hard part, I think the commit above explains the tiny bit leftover. The purpose of the weird escape stuff is just:
This PR is done now. I am going to:
I will complete this later this evening. |
Implementing
SnapshotValueReader
is the first step. One key trick:gradlew test
is failing, try agradlew clean
then try again. This is because of K2.