Skip to content

/ bsearchtools

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a warning when an indexed DFI column is modified ? #5

Closed
digEmAll opened this issue Nov 10, 2016 · 2 comments
Closed

Add a warning when an indexed DFI column is modified ? #5

digEmAll opened this issue Nov 10, 2016 · 2 comments
Labels
bug

Comments

@digEmAll
Copy link
Owner

@digEmAll digEmAll commented Nov 10, 2016 •
edited

Should we add a warning when an indexed DFI column is modified ?
This means overriding all the data.frame and matrix replacement operators...

[<-.data.frame
$<-.data.frame
[[<-.data.frame
and the one used by matrix objects
@digEmAll digEmAll added bug and removed enhancement labels Dec 10, 2016
@digEmAll
Copy link
Owner Author

@digEmAll digEmAll commented Dec 10, 2016 •
edited

Overriding all the replacement operators for data.frame and matrix is tricky and it will make replacements operations for non-indexed columns slower...
Th DFI objects are supposed to be used as "read-only repository" of indexes, so, in order to avoid the risk to use a DFI object with invalid indexes without warning, we're going to introduce a breaking change and make DFI objects not-inheriting from data.frame or matrix anymore.

Changing this issue label into BUG
@digEmAll digEmAll closed this Dec 10, 2016
@digEmAll digEmAll reopened this Dec 10, 2016
@digEmAll digEmAll mentioned this issue Dec 11, 2016
Closed
@digEmAll
Copy link
Owner Author

@digEmAll digEmAll commented Dec 12, 2016

Fixed in v0.0.47 ea9932c
@digEmAll digEmAll closed this Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@digEmAll
You can’t perform that action at this time.