fix: prevent error about lock being acquired by the current PR #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spartakovic
reviewed
May 9, 2023
pkg/gcp/gcp_lock.go
Outdated
| @@ -20,10 +21,14 @@ func (googleLock *GoogleStorageLock) Lock(transactionId int, resource string) (b | |||
| if err != nil { | |||
| fmt.Printf("failed to get lock: %v\n", err) | |||
| } | |||
| if existingLockTransactionId != nil { | |||
| if existingLockTransactionId != nil && *existingLockTransactionId != transactionId { | |||
There was a problem hiding this comment.
I think this kind of logic should actually live a layer above, otherwise we will have to repeat it for each lock provider
fleroux514
force-pushed
the
chore/debug-fleroux
branch
from
838d1fb
to
2b55f06
Compare
Spartakovic
approved these changes
May 9, 2023
ben-of-codecraft
pushed a commit
to ben-of-codecraft/digger
that referenced
this pull request
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent the following