Skip to content

Commit

Permalink
chore: develop on Node 20, CI with 16.17.1 + 18.17.1 + 20 (#23)
Browse files Browse the repository at this point in the history
This is very similar to [digidem/multi-core-indexer#35][0].

This change updates this project's Node versions:

- Develop on Node 20 by updating `.nvmrc`.

- CI should test on Node 20, 18.17.1, and 16.17.1.

- Require this version in the `engines` field.

This update also causes npm to update, which means that the package
lockfile changed.

Node 16.17.1 and 18.17.1 match versions of nodejs-mobile-react-native,
used by CoMapeo-mobile. nodejs-mobile has the same major & minor
versions as Node, but [different patch versions][1]. For example,
nodejs-mobile-react-native@16.17.10 corresponds to Node 16.17.1.

[0]: digidem/multi-core-indexer#35
[1]: https://github.com/nodejs-mobile/nodejs-mobile-react-native/tree/51afe46d36d3776d1bfe7158073897216b55d7f2#versioning

BREAKING CHANGE: Node 16.17.1+ is now required.
  • Loading branch information
EvanHahn committed Jan 22, 2024
1 parent 4e94844 commit c39ed31
Show file tree
Hide file tree
Showing 5 changed files with 2,916 additions and 1,525 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/node.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:

strategy:
matrix:
node-version: [14.x, 16.x, 18.x]
node-version: [16.17.1, 18.17.1, 20.x]

steps:
- uses: actions/checkout@v2
Expand Down
1 change: 1 addition & 0 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
engine-strict=true
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
14
20
Loading

0 comments on commit c39ed31

Please sign in to comment.