Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: develop on Node 20, CI with 16.17.x + 18 + 20 #35

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

EvanHahn
Copy link
Contributor

@EvanHahn EvanHahn commented Jan 19, 2024

Update: this title and description is slightly wrong. See the merged commit for the final full details.

This change updates this project's Node versions:

  • Develop on Node 20 by updating .nvmrc.

  • CI should test on Node 20, 18, and 16.17.x.

Node 16.17.x matches the version used by CoMapeo-mobile, which is nodejs-mobile-react-native@16.17.10. (We can't specify Node 16.17.10 exactly because it does not exist; the patch version is specific to nodejs-mobile-react-native.)

This change updates this project's Node versions:

- Develop on Node 20 by updating `.nvmrc`.

- CI should test on Node 20, 18, and 16.17.x.

Node 16.17.x matches the version used by CoMapeo-mobile, which is
nodejs-mobile-react-native@16.17.10. (We can't specify Node 16.17.10
exactly because [it does not exist][0]; [the patch version is specific
to nodejs-mobile-react-native][1].)

[0]: https://nodejs.org/dist/
[1]: https://github.com/nodejs-mobile/nodejs-mobile-react-native/tree/51afe46d36d3776d1bfe7158073897216b55d7f2#versioning
@EvanHahn EvanHahn changed the title chore: develop on Node 20, CI with 16.17.10 + 18 + 20 chore: develop on Node 20, CI with 16.17.x + 18 + 20 Jan 19, 2024
@EvanHahn EvanHahn marked this pull request as ready for review January 19, 2024 02:08
Copy link
Member

@gmaclennan gmaclennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as long as CI passes with the changes to version numbers, go ahead and merge

.github/workflows/node.js.yml Outdated Show resolved Hide resolved
EvanHahn and others added 2 commits January 19, 2024 07:31
Co-authored-by: Gregor MacLennan <gmaclennan@digital-democracy.org>
@EvanHahn EvanHahn merged commit b85c3b6 into main Jan 19, 2024
4 checks passed
@EvanHahn EvanHahn deleted the update-node-versions branch January 19, 2024 13:41
EvanHahn added a commit to digidem/mapeo-sqlite-indexer that referenced this pull request Jan 22, 2024
This is very similar to [digidem/multi-core-indexer#35][0].

This change updates this project's Node versions:

- Develop on Node 20 by updating `.nvmrc`.

- CI should test on Node 20, 18.17.1, and 16.17.1.

This update also causes npm to update, which means that the package
lockfile changed.

Node 16.17.1 and 18.17.1 match versions of nodejs-mobile-react-native,
used by CoMapeo-mobile. nodejs-mobile has the same major & minor
versions as Node, but [different patch versions][1]. For example,
nodejs-mobile-react-native@16.17.10 corresponds to Node 16.17.1.

[0]: digidem/multi-core-indexer#35
[1]: https://github.com/nodejs-mobile/nodejs-mobile-react-native/tree/51afe46d36d3776d1bfe7158073897216b55d7f2#versioning

BREAKING CHANGE: Node 16.17.1+ is now required.
EvanHahn added a commit to digidem/mapeo-sqlite-indexer that referenced this pull request Jan 22, 2024
This is very similar to [digidem/multi-core-indexer#35][0].

This change updates this project's Node versions:

- Develop on Node 20 by updating `.nvmrc`.

- CI should test on Node 20, 18.17.1, and 16.17.1.

- Require this version in the `engines` field.

This update also causes npm to update, which means that the package
lockfile changed.

Node 16.17.1 and 18.17.1 match versions of nodejs-mobile-react-native,
used by CoMapeo-mobile. nodejs-mobile has the same major & minor
versions as Node, but [different patch versions][1]. For example,
nodejs-mobile-react-native@16.17.10 corresponds to Node 16.17.1.

[0]: digidem/multi-core-indexer#35
[1]: https://github.com/nodejs-mobile/nodejs-mobile-react-native/tree/51afe46d36d3776d1bfe7158073897216b55d7f2#versioning

BREAKING CHANGE: Node 16.17.1+ is now required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants