chore: develop on Node 20, CI with 16.17.1 + 18.17.1 + 20 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is very similar to [digidem/multi-core-indexer#35][0]. This change updates this project's Node versions: - Develop on Node 20 by updating `.nvmrc`. - CI should test on Node 20, 18.17.1, and 16.17.1. This update also causes npm to update, which means that the package lockfile changed. Node 16.17.1 and 18.17.1 match versions of nodejs-mobile-react-native, used by CoMapeo-mobile. nodejs-mobile has the same major & minor versions as Node, but [different patch versions][1]. For example, nodejs-mobile-react-native@16.17.10 corresponds to Node 16.17.1. [0]: digidem/multi-core-indexer#35 [1]: https://github.com/nodejs-mobile/nodejs-mobile-react-native/tree/51afe46d36d3776d1bfe7158073897216b55d7f2#versioning BREAKING CHANGE: Node 16.17.1+ is now required.
Pull Request Test Coverage Report for Build 7613205858
💛 - Coveralls |
gmaclennan
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
Is there a way to specify the npm version? We often have issues with this, e.g. if one of us downgrade the npm version for our Node 20 local install, then do npm install and mangle the lock file. If there is a way to specify the npm version then it would be good to include in this PR.
|
Done in 9f9bab5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very similar to digidem/multi-core-indexer#35.
Unlike that PR, this update also causes npm to update, which means that the package lockfile changed.