Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Found vulnerabilities after 'npm install' #68

Closed
onlycs opened this issue Sep 29, 2020 · 2 comments
Closed

Found vulnerabilities after 'npm install' #68

onlycs opened this issue Sep 29, 2020 · 2 comments

Comments

@onlycs
Copy link

onlycs commented Sep 29, 2020

after running npm install I get:

found 75 vulnerabilities (57 low, 3 moderate, 15 high)
  run `npm audit fix` to fix them, or `npm audit` for details

But Dopamine Runs Fine.

Are the vulnerabilities bad?

@digimezzo
Copy link
Owner

@dragonBall561 There is no reason to be alarmed. NPM checks dependencies of all packages. The vulnerabilities are in components that Dopamine uses, and in sub-components of those components. Trying to fix those, is madness.
Here is an interesting article about this: https://www.voitanos.io/blog/don-t-be-alarmed-by-vulnerabilities-after-running-npm-install/

@dertuxmalwieder
Copy link

dertuxmalwieder commented Mar 30, 2023

Here is an interesting article about this: https://www.voitanos.io/blog/don-t-be-alarmed-by-vulnerabilities-after-running-npm-install/

That article (an opinion piece) basically says that, if a vulnerability was found, it does exist and the author won’t care anyway.

Among the several reasons why I, personally, think that the move towards Electron was a bad idea, this is one of them. Yes, you will fetch dependencies with security problems, and no, this is not something you should ignore.

I would prefer software that I install and use to have no known security problems, to be honest.

@digimezzo digimezzo unpinned this issue Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants