Feat/switch strict mode to true #127
Conversation
| @@ -9,21 +9,21 @@ export class InputComponent extends BaseComponent { | |||
| * The input field. | |||
| */ | |||
| @query('#content') | |||
| content: HTMLInputElement; | |||
| content!: HTMLInputElement; | |||
There was a problem hiding this comment.
what does this do exactly? ( just curious )
There was a problem hiding this comment.
it is to make sure the variables are never null or undefined
https://lit.dev/docs/components/shadow-dom/
There was a problem hiding this comment.
But it actually prevents TS from doing the type check. In the case of LitElement, it might be semi-safe, since you "can be sure" that the template contains the element (if you're confident that you never make mistakes, which I am not of myself, for example)... but it will lead to runtime errors when trying to access the element before rendering, or when using it wrongly with state (see other comment).
There was a problem hiding this comment.
We need to take a look at this again and decide what (and why) we want to do this.
There was a problem hiding this comment.
Ah, @arnevandoorslaer, I forgot about this... can you take another look at it tomorrow? I'd actually prefer to never use that syntax, and simply check for undefined values when they're used (explicitly or using ?. or ?? operators), but maybe you can convince me if you really think they have a huge advantage.
Co-authored-by: Arthur Joppart <38424924+BelgianNoise@users.noreply.github.com>
rdf-quads didn't have typings |
| @@ -9,21 +9,21 @@ export class InputComponent extends BaseComponent { | |||
| * The input field. | |||
| */ | |||
| @query('#content') | |||
| content: HTMLInputElement; | |||
| content!: HTMLInputElement; | |||
There was a problem hiding this comment.
But it actually prevents TS from doing the type check. In the case of LitElement, it might be semi-safe, since you "can be sure" that the template contains the element (if you're confident that you never make mistakes, which I am not of myself, for example)... but it will lead to runtime errors when trying to access the element before rendering, or when using it wrongly with state (see other comment).
Co-authored-by: Wouter Termont <woutermont@gmail.com>
Co-authored-by: Wouter Termont <woutermont@gmail.com>
Signed-off-by: Wouter Termont <woutermont@gmail.com>
Signed-off-by: Wouter Termont <woutermont@gmail.com>
packages/semcom-node/lib/component/services/component-transformer.service.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Wouter Termont <woutermont@gmail.com>
No description provided.