Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speedy: rollback within exercise #9040

Merged
merged 2 commits into from
Mar 8, 2021
Merged

Speedy: rollback within exercise #9040

merged 2 commits into from
Mar 8, 2021

Conversation

nickchapman-da
Copy link
Contributor

@nickchapman-da nickchapman-da commented Mar 5, 2021 •
edited
Loading

Build the correct transactions when exceptions are thrown during exercise.

This requires calling abortExercises if a KCloseExercise continuation frame is encountered whilst unwinding the stack when an exception is thrown.

changelog_begin
changelog_end

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@nickchapman-da
WIP
5be2260 
At a baseline test in RollbackTest for an exercise when no exception thrown.

changelog_begin
changelog_end
@nickchapman-da nickchapman-da added the component/daml-engine DAML-LF Engine & Interpreter label Mar 5, 2021
remyhaemmerle-da
remyhaemmerle-da approved these changes Mar 8, 2021
View reviewed changes
Copy link
Collaborator

@remyhaemmerle-da remyhaemmerle-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@nickchapman-da nickchapman-da marked this pull request as ready for review March 8, 2021 12:50
@nickchapman-da nickchapman-da merged commit 0c4d8ac into main Mar 8, 2021
@nickchapman-da nickchapman-da deleted the nick-rollback-within-exercise branch March 8, 2021 15:11
azure-pipelines bot pushed a commit that referenced this pull request Mar 10, 2021
release 1.11.0-snapshot.20210309.6463.0.f7abca91
afc2c89 
This PR has been created by a script, which is not very smart
and does not have all the context. Please do double-check that
the version prefix is correct before merging.

@S11001001 is in charge of this release.

Commit log:
```
f7abca9 fix readme in create-daml-app: add npm install (#9060)
e04bd91 Move Daml Profiler to EE version of sandbox/sandbox-classic (#9054)
7859bc1 inline help: scripts JSON API clarification (#9057)
642385a Upgrade elliptic dependency to address vulnerabilities (#9055)
f2b9f11 Check that only the command signed payload goes through (#9053)
5197374 Build SDK EE tarball (#9049)
1bec211 Add tests for client bindings (#9036)
27fd932 Disclose transactions in the flat transactions stream only to the stakeholders - test case [DPP-276] (#9028)
45b3375 Introduce a helper to limit signing to commands (#9050)
0c4d8ac Speedy: rollback within exercise (#9040)
caa023b ci/cron/check: remove dade-assist calls (#9048)
85f0965 LF: fix archive decoder for GREATER_DATE (#9047)
121534c ci/cron/check: low-hanging perf improvement (#9042)
fb0bd82 update NOTICES file (#9045)
4fd42a6 reduce noise on daily tests (#9039)
5d88c08 Bump ghcide (#9041)
41d62ea send CI failures on separate channel (#9038)
e26d006 slack: reduce @here mentions (#9037)
ae11036 Add more shared infrastructure for non-repudiation testing (#9035)
7514074 Speedy: building transactions with rollback (#8983)
98410e7 update compat versions for 1.11.0-snapshot.20210304.6422.0.d3d5042a (#9032)
0f1d2a9 Upgrade akka to 2.6.13 (#9026)
b1a59d0 Release SDK 1.11.0 RC 2 (#9031)
41e0493 Fix --extract option in ledger api test tool (#9029)
0281b44 -Werror all the things (#9027)
2c08586 Expose Daml stacktraces for Daml Script errors (#9025)
c7ee410 Use DA.Map in triggers if available (#9023)
d347934 Make non-repudiation PostgreSQL back-end certificate adding idempotent (#9024)
eaf7fb6 Add non-repudiation API (#8982)
5a3c952 Document latency of Windows ad-hoc machine software installation (#9022)
3758b57 pkg deps: Move all dalfs to package dependency directory (#9002)
f70d339 update compat versions for 1.10.2 (#9016)
e542128 Improve errors on duplicate record field names (#9010)
65fbcfe Move execution of commands out of Runner (#9009)
2688ad6 autorelease: improved PR message (#9008)
185e916 Release 1.10.2 (#9006)
4ed3f1a Cut a snapshot release for the 1.8.0 special patch (#8998)
ba1456f rotate release duty after 1.11.0-snapshot.20210302.6414.0.72870630 (#8992)
259bf68 compat: fix killing stale sandbox(es) (#9003)
32dc8b0 Include stack traces for all ScriptF commands (#8999)
1525957 release 1.11.0-snapshot.20210302.6414.0.72870630 (#8991)
926949e Use single party submit/submitTree where appropriate (#8995)
```
Changelog:
```

- [Daml Compiler] Fix a bug where passing `--ghc-option=-Werror` also
  produced errors for warnings produced by `-Wmissing-signatures` even
  if the user did not explicitly enable this.

- [Daml Script] When running Daml Script on the command line you will
  now see a Daml stacktrace on failures to interact with the ledger
  which makes it significantly easier to track down which of the calls
  fails. By default, you will only get the callsite of functions like
  `submit`. To extend the stack trace, add `HasCallStack` constraints
  to functions and those will also be included.

- [Triggers] The trigger library now uses `DA.Map` instead of the
  deprecated `DA.Next.Map` if the targeted Daml-LF version supports it.
  This is a breaking change: Code that interfaced with the triggers
  library using `DA.Next.Map`, e.g. with
  `Daml.Trigger.getCommandsInFlight` or `Daml.Trigger.Assert.testRule`,
  will need to be changed to use `DA.Map` instead.
```

CHANGELOG_BEGIN
CHANGELOG_END
cocreature pushed a commit that referenced this pull request Mar 10, 2021
@cocreature
release 1.11.0-snapshot.20210309.6463.0.f7abca91
428e6cd 
This PR has been created by a script, which is not very smart
and does not have all the context. Please do double-check that
the version prefix is correct before merging.

@S11001001 is in charge of this release.

Commit log:
```
f7abca9 fix readme in create-daml-app: add npm install (#9060)
e04bd91 Move Daml Profiler to EE version of sandbox/sandbox-classic (#9054)
7859bc1 inline help: scripts JSON API clarification (#9057)
642385a Upgrade elliptic dependency to address vulnerabilities (#9055)
f2b9f11 Check that only the command signed payload goes through (#9053)
5197374 Build SDK EE tarball (#9049)
1bec211 Add tests for client bindings (#9036)
27fd932 Disclose transactions in the flat transactions stream only to the stakeholders - test case [DPP-276] (#9028)
45b3375 Introduce a helper to limit signing to commands (#9050)
0c4d8ac Speedy: rollback within exercise (#9040)
caa023b ci/cron/check: remove dade-assist calls (#9048)
85f0965 LF: fix archive decoder for GREATER_DATE (#9047)
121534c ci/cron/check: low-hanging perf improvement (#9042)
fb0bd82 update NOTICES file (#9045)
4fd42a6 reduce noise on daily tests (#9039)
5d88c08 Bump ghcide (#9041)
41d62ea send CI failures on separate channel (#9038)
e26d006 slack: reduce @here mentions (#9037)
ae11036 Add more shared infrastructure for non-repudiation testing (#9035)
7514074 Speedy: building transactions with rollback (#8983)
98410e7 update compat versions for 1.11.0-snapshot.20210304.6422.0.d3d5042a (#9032)
0f1d2a9 Upgrade akka to 2.6.13 (#9026)
b1a59d0 Release SDK 1.11.0 RC 2 (#9031)
41e0493 Fix --extract option in ledger api test tool (#9029)
0281b44 -Werror all the things (#9027)
2c08586 Expose Daml stacktraces for Daml Script errors (#9025)
c7ee410 Use DA.Map in triggers if available (#9023)
d347934 Make non-repudiation PostgreSQL back-end certificate adding idempotent (#9024)
eaf7fb6 Add non-repudiation API (#8982)
5a3c952 Document latency of Windows ad-hoc machine software installation (#9022)
3758b57 pkg deps: Move all dalfs to package dependency directory (#9002)
f70d339 update compat versions for 1.10.2 (#9016)
e542128 Improve errors on duplicate record field names (#9010)
65fbcfe Move execution of commands out of Runner (#9009)
2688ad6 autorelease: improved PR message (#9008)
185e916 Release 1.10.2 (#9006)
4ed3f1a Cut a snapshot release for the 1.8.0 special patch (#8998)
ba1456f rotate release duty after 1.11.0-snapshot.20210302.6414.0.72870630 (#8992)
259bf68 compat: fix killing stale sandbox(es) (#9003)
32dc8b0 Include stack traces for all ScriptF commands (#8999)
1525957 release 1.11.0-snapshot.20210302.6414.0.72870630 (#8991)
926949e Use single party submit/submitTree where appropriate (#8995)
```
Changelog:
```

- [Daml Compiler] Fix a bug where passing `--ghc-option=-Werror` also
  produced errors for warnings produced by `-Wmissing-signatures` even
  if the user did not explicitly enable this.

- [Daml Script] When running Daml Script on the command line you will
  now see a Daml stacktrace on failures to interact with the ledger
  which makes it significantly easier to track down which of the calls
  fails. By default, you will only get the callsite of functions like
  `submit`. To extend the stack trace, add `HasCallStack` constraints
  to functions and those will also be included.

- [Triggers] The trigger library now uses `DA.Map` instead of the
  deprecated `DA.Next.Map` if the targeted Daml-LF version supports it.
  This is a breaking change: Code that interfaced with the triggers
  library using `DA.Next.Map`, e.g. with
  `Daml.Trigger.getCommandsInFlight` or `Daml.Trigger.Assert.testRule`,
  will need to be changed to use `DA.Map` instead.
```

CHANGELOG_BEGIN
CHANGELOG_END
mergify bot pushed a commit that referenced this pull request Mar 10, 2021
@azure-pipelines @cocreature
release 1.12.0-snapshot.20210309.6463.0.f7abca91 (#9061)
5aac471 
* release 1.11.0-snapshot.20210309.6463.0.f7abca91

This PR has been created by a script, which is not very smart
and does not have all the context. Please do double-check that
the version prefix is correct before merging.

@S11001001 is in charge of this release.

Commit log:
```
f7abca9 fix readme in create-daml-app: add npm install (#9060)
e04bd91 Move Daml Profiler to EE version of sandbox/sandbox-classic (#9054)
7859bc1 inline help: scripts JSON API clarification (#9057)
642385a Upgrade elliptic dependency to address vulnerabilities (#9055)
f2b9f11 Check that only the command signed payload goes through (#9053)
5197374 Build SDK EE tarball (#9049)
1bec211 Add tests for client bindings (#9036)
27fd932 Disclose transactions in the flat transactions stream only to the stakeholders - test case [DPP-276] (#9028)
45b3375 Introduce a helper to limit signing to commands (#9050)
0c4d8ac Speedy: rollback within exercise (#9040)
caa023b ci/cron/check: remove dade-assist calls (#9048)
85f0965 LF: fix archive decoder for GREATER_DATE (#9047)
121534c ci/cron/check: low-hanging perf improvement (#9042)
fb0bd82 update NOTICES file (#9045)
4fd42a6 reduce noise on daily tests (#9039)
5d88c08 Bump ghcide (#9041)
41d62ea send CI failures on separate channel (#9038)
e26d006 slack: reduce @here mentions (#9037)
ae11036 Add more shared infrastructure for non-repudiation testing (#9035)
7514074 Speedy: building transactions with rollback (#8983)
98410e7 update compat versions for 1.11.0-snapshot.20210304.6422.0.d3d5042a (#9032)
0f1d2a9 Upgrade akka to 2.6.13 (#9026)
b1a59d0 Release SDK 1.11.0 RC 2 (#9031)
41e0493 Fix --extract option in ledger api test tool (#9029)
0281b44 -Werror all the things (#9027)
2c08586 Expose Daml stacktraces for Daml Script errors (#9025)
c7ee410 Use DA.Map in triggers if available (#9023)
d347934 Make non-repudiation PostgreSQL back-end certificate adding idempotent (#9024)
eaf7fb6 Add non-repudiation API (#8982)
5a3c952 Document latency of Windows ad-hoc machine software installation (#9022)
3758b57 pkg deps: Move all dalfs to package dependency directory (#9002)
f70d339 update compat versions for 1.10.2 (#9016)
e542128 Improve errors on duplicate record field names (#9010)
65fbcfe Move execution of commands out of Runner (#9009)
2688ad6 autorelease: improved PR message (#9008)
185e916 Release 1.10.2 (#9006)
4ed3f1a Cut a snapshot release for the 1.8.0 special patch (#8998)
ba1456f rotate release duty after 1.11.0-snapshot.20210302.6414.0.72870630 (#8992)
259bf68 compat: fix killing stale sandbox(es) (#9003)
32dc8b0 Include stack traces for all ScriptF commands (#8999)
1525957 release 1.11.0-snapshot.20210302.6414.0.72870630 (#8991)
926949e Use single party submit/submitTree where appropriate (#8995)
```
Changelog:
```

- [Daml Compiler] Fix a bug where passing `--ghc-option=-Werror` also
  produced errors for warnings produced by `-Wmissing-signatures` even
  if the user did not explicitly enable this.

- [Daml Script] When running Daml Script on the command line you will
  now see a Daml stacktrace on failures to interact with the ledger
  which makes it significantly easier to track down which of the calls
  fails. By default, you will only get the callsite of functions like
  `submit`. To extend the stack trace, add `HasCallStack` constraints
  to functions and those will also be included.

- [Triggers] The trigger library now uses `DA.Map` instead of the
  deprecated `DA.Next.Map` if the targeted Daml-LF version supports it.
  This is a breaking change: Code that interfaced with the triggers
  library using `DA.Next.Map`, e.g. with
  `Daml.Trigger.getCommandsInFlight` or `Daml.Trigger.Assert.testRule`,
  will need to be changed to use `DA.Map` instead.
```

CHANGELOG_BEGIN
CHANGELOG_END

* 1.12 not 1.11

changelog_begin
changelog_end

Co-authored-by: Azure Pipelines DAML Build <support@digitalasset.com>
Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
remyhaemmerle-da pushed a commit that referenced this pull request Mar 11, 2021
@azure-pipelines @cocreature @remyhaemmerle-da
release 1.12.0-snapshot.20210309.6463.0.f7abca91 (#9061)
d3658fb 
* release 1.11.0-snapshot.20210309.6463.0.f7abca91

This PR has been created by a script, which is not very smart
and does not have all the context. Please do double-check that
the version prefix is correct before merging.

@S11001001 is in charge of this release.

Commit log:
```
f7abca9 fix readme in create-daml-app: add npm install (#9060)
e04bd91 Move Daml Profiler to EE version of sandbox/sandbox-classic (#9054)
7859bc1 inline help: scripts JSON API clarification (#9057)
642385a Upgrade elliptic dependency to address vulnerabilities (#9055)
f2b9f11 Check that only the command signed payload goes through (#9053)
5197374 Build SDK EE tarball (#9049)
1bec211 Add tests for client bindings (#9036)
27fd932 Disclose transactions in the flat transactions stream only to the stakeholders - test case [DPP-276] (#9028)
45b3375 Introduce a helper to limit signing to commands (#9050)
0c4d8ac Speedy: rollback within exercise (#9040)
caa023b ci/cron/check: remove dade-assist calls (#9048)
85f0965 LF: fix archive decoder for GREATER_DATE (#9047)
121534c ci/cron/check: low-hanging perf improvement (#9042)
fb0bd82 update NOTICES file (#9045)
4fd42a6 reduce noise on daily tests (#9039)
5d88c08 Bump ghcide (#9041)
41d62ea send CI failures on separate channel (#9038)
e26d006 slack: reduce @here mentions (#9037)
ae11036 Add more shared infrastructure for non-repudiation testing (#9035)
7514074 Speedy: building transactions with rollback (#8983)
98410e7 update compat versions for 1.11.0-snapshot.20210304.6422.0.d3d5042a (#9032)
0f1d2a9 Upgrade akka to 2.6.13 (#9026)
b1a59d0 Release SDK 1.11.0 RC 2 (#9031)
41e0493 Fix --extract option in ledger api test tool (#9029)
0281b44 -Werror all the things (#9027)
2c08586 Expose Daml stacktraces for Daml Script errors (#9025)
c7ee410 Use DA.Map in triggers if available (#9023)
d347934 Make non-repudiation PostgreSQL back-end certificate adding idempotent (#9024)
eaf7fb6 Add non-repudiation API (#8982)
5a3c952 Document latency of Windows ad-hoc machine software installation (#9022)
3758b57 pkg deps: Move all dalfs to package dependency directory (#9002)
f70d339 update compat versions for 1.10.2 (#9016)
e542128 Improve errors on duplicate record field names (#9010)
65fbcfe Move execution of commands out of Runner (#9009)
2688ad6 autorelease: improved PR message (#9008)
185e916 Release 1.10.2 (#9006)
4ed3f1a Cut a snapshot release for the 1.8.0 special patch (#8998)
ba1456f rotate release duty after 1.11.0-snapshot.20210302.6414.0.72870630 (#8992)
259bf68 compat: fix killing stale sandbox(es) (#9003)
32dc8b0 Include stack traces for all ScriptF commands (#8999)
1525957 release 1.11.0-snapshot.20210302.6414.0.72870630 (#8991)
926949e Use single party submit/submitTree where appropriate (#8995)
```
Changelog:
```

- [Daml Compiler] Fix a bug where passing `--ghc-option=-Werror` also
  produced errors for warnings produced by `-Wmissing-signatures` even
  if the user did not explicitly enable this.

- [Daml Script] When running Daml Script on the command line you will
  now see a Daml stacktrace on failures to interact with the ledger
  which makes it significantly easier to track down which of the calls
  fails. By default, you will only get the callsite of functions like
  `submit`. To extend the stack trace, add `HasCallStack` constraints
  to functions and those will also be included.

- [Triggers] The trigger library now uses `DA.Map` instead of the
  deprecated `DA.Next.Map` if the targeted Daml-LF version supports it.
  This is a breaking change: Code that interfaced with the triggers
  library using `DA.Next.Map`, e.g. with
  `Daml.Trigger.getCommandsInFlight` or `Daml.Trigger.Assert.testRule`,
  will need to be changed to use `DA.Map` instead.
```

CHANGELOG_BEGIN
CHANGELOG_END

* 1.12 not 1.11

changelog_begin
changelog_end

Co-authored-by: Azure Pipelines DAML Build <support@digitalasset.com>
Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyhaemmerle-da remyhaemmerle-da remyhaemmerle-da approved these changes

@cocreature cocreature Awaiting requested review from cocreature

@hurryabit hurryabit Awaiting requested review from hurryabit

Assignees
No one assigned
Labels
component/daml-engine DAML-LF Engine & Interpreter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nickchapman-da @remyhaemmerle-da