Include stack traces for all ScriptF commands #8999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds stack traces to all ScriptF commands and handles those in the converter. Those stack traces are not yet used. To ease review, I’ve left that for a separate PR. The plan is to use this to tackle #8754. changelog_begin changelog_end
cocreature
force-pushed
the
script-stacktrace
branch
from
9717c4a
to
b647876
Compare
azure-pipelines bot
pushed a commit
that referenced
this pull request
Mar 3, 2021
This PR has been created by a script, which is not very smart and does not have all the context. Please do double-check that the version prefix is correct before merging. @S11001001 is in charge of this release. Commit log: ``` 8714b3d . 6259185 . f830f2a temp test commit 8a1b01b autorelease: improved PR message 185e916 Release 1.10.2 (#9006) 4ed3f1a Cut a snapshot release for the 1.8.0 special patch (#8998) ba1456f rotate release duty after 1.11.0-snapshot.20210302.6414.0.72870630 (#8992) 259bf68 compat: fix killing stale sandbox(es) (#9003) 32dc8b0 Include stack traces for all ScriptF commands (#8999) 1525957 release 1.11.0-snapshot.20210302.6414.0.72870630 (#8991) 926949e Use single party submit/submitTree where appropriate (#8995) ``` Changelog: ``` [Widget] some changelog entry ``` CHANGELOG_BEGIN CHANGELOG_END
azure-pipelines bot
pushed a commit
that referenced
this pull request
Mar 10, 2021
This PR has been created by a script, which is not very smart and does not have all the context. Please do double-check that the version prefix is correct before merging. @S11001001 is in charge of this release. Commit log: ``` f7abca9 fix readme in create-daml-app: add npm install (#9060) e04bd91 Move Daml Profiler to EE version of sandbox/sandbox-classic (#9054) 7859bc1 inline help: scripts JSON API clarification (#9057) 642385a Upgrade elliptic dependency to address vulnerabilities (#9055) f2b9f11 Check that only the command signed payload goes through (#9053) 5197374 Build SDK EE tarball (#9049) 1bec211 Add tests for client bindings (#9036) 27fd932 Disclose transactions in the flat transactions stream only to the stakeholders - test case [DPP-276] (#9028) 45b3375 Introduce a helper to limit signing to commands (#9050) 0c4d8ac Speedy: rollback within exercise (#9040) caa023b ci/cron/check: remove dade-assist calls (#9048) 85f0965 LF: fix archive decoder for GREATER_DATE (#9047) 121534c ci/cron/check: low-hanging perf improvement (#9042) fb0bd82 update NOTICES file (#9045) 4fd42a6 reduce noise on daily tests (#9039) 5d88c08 Bump ghcide (#9041) 41d62ea send CI failures on separate channel (#9038) e26d006 slack: reduce @here mentions (#9037) ae11036 Add more shared infrastructure for non-repudiation testing (#9035) 7514074 Speedy: building transactions with rollback (#8983) 98410e7 update compat versions for 1.11.0-snapshot.20210304.6422.0.d3d5042a (#9032) 0f1d2a9 Upgrade akka to 2.6.13 (#9026) b1a59d0 Release SDK 1.11.0 RC 2 (#9031) 41e0493 Fix --extract option in ledger api test tool (#9029) 0281b44 -Werror all the things (#9027) 2c08586 Expose Daml stacktraces for Daml Script errors (#9025) c7ee410 Use DA.Map in triggers if available (#9023) d347934 Make non-repudiation PostgreSQL back-end certificate adding idempotent (#9024) eaf7fb6 Add non-repudiation API (#8982) 5a3c952 Document latency of Windows ad-hoc machine software installation (#9022) 3758b57 pkg deps: Move all dalfs to package dependency directory (#9002) f70d339 update compat versions for 1.10.2 (#9016) e542128 Improve errors on duplicate record field names (#9010) 65fbcfe Move execution of commands out of Runner (#9009) 2688ad6 autorelease: improved PR message (#9008) 185e916 Release 1.10.2 (#9006) 4ed3f1a Cut a snapshot release for the 1.8.0 special patch (#8998) ba1456f rotate release duty after 1.11.0-snapshot.20210302.6414.0.72870630 (#8992) 259bf68 compat: fix killing stale sandbox(es) (#9003) 32dc8b0 Include stack traces for all ScriptF commands (#8999) 1525957 release 1.11.0-snapshot.20210302.6414.0.72870630 (#8991) 926949e Use single party submit/submitTree where appropriate (#8995) ``` Changelog: ``` - [Daml Compiler] Fix a bug where passing `--ghc-option=-Werror` also produced errors for warnings produced by `-Wmissing-signatures` even if the user did not explicitly enable this. - [Daml Script] When running Daml Script on the command line you will now see a Daml stacktrace on failures to interact with the ledger which makes it significantly easier to track down which of the calls fails. By default, you will only get the callsite of functions like `submit`. To extend the stack trace, add `HasCallStack` constraints to functions and those will also be included. - [Triggers] The trigger library now uses `DA.Map` instead of the deprecated `DA.Next.Map` if the targeted Daml-LF version supports it. This is a breaking change: Code that interfaced with the triggers library using `DA.Next.Map`, e.g. with `Daml.Trigger.getCommandsInFlight` or `Daml.Trigger.Assert.testRule`, will need to be changed to use `DA.Map` instead. ``` CHANGELOG_BEGIN CHANGELOG_END
cocreature
pushed a commit
that referenced
this pull request
Mar 10, 2021
This PR has been created by a script, which is not very smart and does not have all the context. Please do double-check that the version prefix is correct before merging. @S11001001 is in charge of this release. Commit log: ``` f7abca9 fix readme in create-daml-app: add npm install (#9060) e04bd91 Move Daml Profiler to EE version of sandbox/sandbox-classic (#9054) 7859bc1 inline help: scripts JSON API clarification (#9057) 642385a Upgrade elliptic dependency to address vulnerabilities (#9055) f2b9f11 Check that only the command signed payload goes through (#9053) 5197374 Build SDK EE tarball (#9049) 1bec211 Add tests for client bindings (#9036) 27fd932 Disclose transactions in the flat transactions stream only to the stakeholders - test case [DPP-276] (#9028) 45b3375 Introduce a helper to limit signing to commands (#9050) 0c4d8ac Speedy: rollback within exercise (#9040) caa023b ci/cron/check: remove dade-assist calls (#9048) 85f0965 LF: fix archive decoder for GREATER_DATE (#9047) 121534c ci/cron/check: low-hanging perf improvement (#9042) fb0bd82 update NOTICES file (#9045) 4fd42a6 reduce noise on daily tests (#9039) 5d88c08 Bump ghcide (#9041) 41d62ea send CI failures on separate channel (#9038) e26d006 slack: reduce @here mentions (#9037) ae11036 Add more shared infrastructure for non-repudiation testing (#9035) 7514074 Speedy: building transactions with rollback (#8983) 98410e7 update compat versions for 1.11.0-snapshot.20210304.6422.0.d3d5042a (#9032) 0f1d2a9 Upgrade akka to 2.6.13 (#9026) b1a59d0 Release SDK 1.11.0 RC 2 (#9031) 41e0493 Fix --extract option in ledger api test tool (#9029) 0281b44 -Werror all the things (#9027) 2c08586 Expose Daml stacktraces for Daml Script errors (#9025) c7ee410 Use DA.Map in triggers if available (#9023) d347934 Make non-repudiation PostgreSQL back-end certificate adding idempotent (#9024) eaf7fb6 Add non-repudiation API (#8982) 5a3c952 Document latency of Windows ad-hoc machine software installation (#9022) 3758b57 pkg deps: Move all dalfs to package dependency directory (#9002) f70d339 update compat versions for 1.10.2 (#9016) e542128 Improve errors on duplicate record field names (#9010) 65fbcfe Move execution of commands out of Runner (#9009) 2688ad6 autorelease: improved PR message (#9008) 185e916 Release 1.10.2 (#9006) 4ed3f1a Cut a snapshot release for the 1.8.0 special patch (#8998) ba1456f rotate release duty after 1.11.0-snapshot.20210302.6414.0.72870630 (#8992) 259bf68 compat: fix killing stale sandbox(es) (#9003) 32dc8b0 Include stack traces for all ScriptF commands (#8999) 1525957 release 1.11.0-snapshot.20210302.6414.0.72870630 (#8991) 926949e Use single party submit/submitTree where appropriate (#8995) ``` Changelog: ``` - [Daml Compiler] Fix a bug where passing `--ghc-option=-Werror` also produced errors for warnings produced by `-Wmissing-signatures` even if the user did not explicitly enable this. - [Daml Script] When running Daml Script on the command line you will now see a Daml stacktrace on failures to interact with the ledger which makes it significantly easier to track down which of the calls fails. By default, you will only get the callsite of functions like `submit`. To extend the stack trace, add `HasCallStack` constraints to functions and those will also be included. - [Triggers] The trigger library now uses `DA.Map` instead of the deprecated `DA.Next.Map` if the targeted Daml-LF version supports it. This is a breaking change: Code that interfaced with the triggers library using `DA.Next.Map`, e.g. with `Daml.Trigger.getCommandsInFlight` or `Daml.Trigger.Assert.testRule`, will need to be changed to use `DA.Map` instead. ``` CHANGELOG_BEGIN CHANGELOG_END
mergify bot
pushed a commit
that referenced
this pull request
Mar 10, 2021
* release 1.11.0-snapshot.20210309.6463.0.f7abca91 This PR has been created by a script, which is not very smart and does not have all the context. Please do double-check that the version prefix is correct before merging. @S11001001 is in charge of this release. Commit log: ``` f7abca9 fix readme in create-daml-app: add npm install (#9060) e04bd91 Move Daml Profiler to EE version of sandbox/sandbox-classic (#9054) 7859bc1 inline help: scripts JSON API clarification (#9057) 642385a Upgrade elliptic dependency to address vulnerabilities (#9055) f2b9f11 Check that only the command signed payload goes through (#9053) 5197374 Build SDK EE tarball (#9049) 1bec211 Add tests for client bindings (#9036) 27fd932 Disclose transactions in the flat transactions stream only to the stakeholders - test case [DPP-276] (#9028) 45b3375 Introduce a helper to limit signing to commands (#9050) 0c4d8ac Speedy: rollback within exercise (#9040) caa023b ci/cron/check: remove dade-assist calls (#9048) 85f0965 LF: fix archive decoder for GREATER_DATE (#9047) 121534c ci/cron/check: low-hanging perf improvement (#9042) fb0bd82 update NOTICES file (#9045) 4fd42a6 reduce noise on daily tests (#9039) 5d88c08 Bump ghcide (#9041) 41d62ea send CI failures on separate channel (#9038) e26d006 slack: reduce @here mentions (#9037) ae11036 Add more shared infrastructure for non-repudiation testing (#9035) 7514074 Speedy: building transactions with rollback (#8983) 98410e7 update compat versions for 1.11.0-snapshot.20210304.6422.0.d3d5042a (#9032) 0f1d2a9 Upgrade akka to 2.6.13 (#9026) b1a59d0 Release SDK 1.11.0 RC 2 (#9031) 41e0493 Fix --extract option in ledger api test tool (#9029) 0281b44 -Werror all the things (#9027) 2c08586 Expose Daml stacktraces for Daml Script errors (#9025) c7ee410 Use DA.Map in triggers if available (#9023) d347934 Make non-repudiation PostgreSQL back-end certificate adding idempotent (#9024) eaf7fb6 Add non-repudiation API (#8982) 5a3c952 Document latency of Windows ad-hoc machine software installation (#9022) 3758b57 pkg deps: Move all dalfs to package dependency directory (#9002) f70d339 update compat versions for 1.10.2 (#9016) e542128 Improve errors on duplicate record field names (#9010) 65fbcfe Move execution of commands out of Runner (#9009) 2688ad6 autorelease: improved PR message (#9008) 185e916 Release 1.10.2 (#9006) 4ed3f1a Cut a snapshot release for the 1.8.0 special patch (#8998) ba1456f rotate release duty after 1.11.0-snapshot.20210302.6414.0.72870630 (#8992) 259bf68 compat: fix killing stale sandbox(es) (#9003) 32dc8b0 Include stack traces for all ScriptF commands (#8999) 1525957 release 1.11.0-snapshot.20210302.6414.0.72870630 (#8991) 926949e Use single party submit/submitTree where appropriate (#8995) ``` Changelog: ``` - [Daml Compiler] Fix a bug where passing `--ghc-option=-Werror` also produced errors for warnings produced by `-Wmissing-signatures` even if the user did not explicitly enable this. - [Daml Script] When running Daml Script on the command line you will now see a Daml stacktrace on failures to interact with the ledger which makes it significantly easier to track down which of the calls fails. By default, you will only get the callsite of functions like `submit`. To extend the stack trace, add `HasCallStack` constraints to functions and those will also be included. - [Triggers] The trigger library now uses `DA.Map` instead of the deprecated `DA.Next.Map` if the targeted Daml-LF version supports it. This is a breaking change: Code that interfaced with the triggers library using `DA.Next.Map`, e.g. with `Daml.Trigger.getCommandsInFlight` or `Daml.Trigger.Assert.testRule`, will need to be changed to use `DA.Map` instead. ``` CHANGELOG_BEGIN CHANGELOG_END * 1.12 not 1.11 changelog_begin changelog_end Co-authored-by: Azure Pipelines DAML Build <support@digitalasset.com> Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
remyhaemmerle-da
pushed a commit
that referenced
this pull request
Mar 11, 2021
* release 1.11.0-snapshot.20210309.6463.0.f7abca91 This PR has been created by a script, which is not very smart and does not have all the context. Please do double-check that the version prefix is correct before merging. @S11001001 is in charge of this release. Commit log: ``` f7abca9 fix readme in create-daml-app: add npm install (#9060) e04bd91 Move Daml Profiler to EE version of sandbox/sandbox-classic (#9054) 7859bc1 inline help: scripts JSON API clarification (#9057) 642385a Upgrade elliptic dependency to address vulnerabilities (#9055) f2b9f11 Check that only the command signed payload goes through (#9053) 5197374 Build SDK EE tarball (#9049) 1bec211 Add tests for client bindings (#9036) 27fd932 Disclose transactions in the flat transactions stream only to the stakeholders - test case [DPP-276] (#9028) 45b3375 Introduce a helper to limit signing to commands (#9050) 0c4d8ac Speedy: rollback within exercise (#9040) caa023b ci/cron/check: remove dade-assist calls (#9048) 85f0965 LF: fix archive decoder for GREATER_DATE (#9047) 121534c ci/cron/check: low-hanging perf improvement (#9042) fb0bd82 update NOTICES file (#9045) 4fd42a6 reduce noise on daily tests (#9039) 5d88c08 Bump ghcide (#9041) 41d62ea send CI failures on separate channel (#9038) e26d006 slack: reduce @here mentions (#9037) ae11036 Add more shared infrastructure for non-repudiation testing (#9035) 7514074 Speedy: building transactions with rollback (#8983) 98410e7 update compat versions for 1.11.0-snapshot.20210304.6422.0.d3d5042a (#9032) 0f1d2a9 Upgrade akka to 2.6.13 (#9026) b1a59d0 Release SDK 1.11.0 RC 2 (#9031) 41e0493 Fix --extract option in ledger api test tool (#9029) 0281b44 -Werror all the things (#9027) 2c08586 Expose Daml stacktraces for Daml Script errors (#9025) c7ee410 Use DA.Map in triggers if available (#9023) d347934 Make non-repudiation PostgreSQL back-end certificate adding idempotent (#9024) eaf7fb6 Add non-repudiation API (#8982) 5a3c952 Document latency of Windows ad-hoc machine software installation (#9022) 3758b57 pkg deps: Move all dalfs to package dependency directory (#9002) f70d339 update compat versions for 1.10.2 (#9016) e542128 Improve errors on duplicate record field names (#9010) 65fbcfe Move execution of commands out of Runner (#9009) 2688ad6 autorelease: improved PR message (#9008) 185e916 Release 1.10.2 (#9006) 4ed3f1a Cut a snapshot release for the 1.8.0 special patch (#8998) ba1456f rotate release duty after 1.11.0-snapshot.20210302.6414.0.72870630 (#8992) 259bf68 compat: fix killing stale sandbox(es) (#9003) 32dc8b0 Include stack traces for all ScriptF commands (#8999) 1525957 release 1.11.0-snapshot.20210302.6414.0.72870630 (#8991) 926949e Use single party submit/submitTree where appropriate (#8995) ``` Changelog: ``` - [Daml Compiler] Fix a bug where passing `--ghc-option=-Werror` also produced errors for warnings produced by `-Wmissing-signatures` even if the user did not explicitly enable this. - [Daml Script] When running Daml Script on the command line you will now see a Daml stacktrace on failures to interact with the ledger which makes it significantly easier to track down which of the calls fails. By default, you will only get the callsite of functions like `submit`. To extend the stack trace, add `HasCallStack` constraints to functions and those will also be included. - [Triggers] The trigger library now uses `DA.Map` instead of the deprecated `DA.Next.Map` if the targeted Daml-LF version supports it. This is a breaking change: Code that interfaced with the triggers library using `DA.Next.Map`, e.g. with `Daml.Trigger.getCommandsInFlight` or `Daml.Trigger.Assert.testRule`, will need to be changed to use `DA.Map` instead. ``` CHANGELOG_BEGIN CHANGELOG_END * 1.12 not 1.11 changelog_begin changelog_end Co-authored-by: Azure Pipelines DAML Build <support@digitalasset.com> Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds stack traces to all ScriptF commands and handles those in
the converter. Those stack traces are not yet used. To ease review,
I’ve left that for a separate PR. The plan is to use this to tackle
#8754.
changelog_begin
changelog_end
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.