contract key are mistakenly deleted for nonconsuming choices within transaction

[bitonic]

Right now the following does not work:

template Foo
  with
    p : Party
  where
    signatory p
    maintainer p
    key p : Party

    controller p can
      nonconsuming DoNothing: ()
        do return ()

template Boo
  with
    p : Party
  where
    signatory p
    controller p can
      Fetch: (ContractId Foo)
        do
          fooCid <- fmap fst $ fetchByKey @Foo p
          exercise fooCid DoNothing
          fmap fst $ fetchByKey @Foo p

test = scenario do
  p <- getParty "Party"
  submit p do create Foo with p
  submit p do
    booCid <- create Boo with p
    exercise booCid Fetch

that is, the second fetchByKey in choice Fetch fails. this is due to the fact that we record contract key deletions locally without considering whether the choice is consuming or not, see

daml/daml-lf/transaction/src/main/scala/com/digitalasset/daml/lf/transaction/Transaction.scala

Line 675 in 55d5fa5

keys = mbKey match {

.