Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync head #259

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Sync head #259

merged 1 commit into from
Nov 4, 2020

Conversation

shayne-fletcher
Copy link
Contributor

@shayne-fletcher shayne-fletcher commented Nov 1, 2020

Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very reasonable. Thanks for taking such meticulous care of this project!

@@ -2,10 +2,13 @@ dist/
dist-newstyle/
.ghc.environment.*
ghc/
ghc-lib-parser/
ghc-lib/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I correct that it should have always been like this and this is just fixing the situation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's right.

@hurryabit
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@shayne-fletcher
Copy link
Contributor Author

@hurryabit A new version of stack has been pushed that should solve the Windows build failure. Please give this another/azp run. Thank-you.

@hurryabit
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@shayne-fletcher
Copy link
Contributor Author

@hurryabit Outstanding. Land please?

@hurryabit hurryabit merged commit fe1daad into digital-asset:master Nov 4, 2020
@hurryabit
Copy link
Contributor

Yes, Sir! Landed! Thanks for taking care of this.

@shayne-fletcher shayne-fletcher deleted the sync-head branch November 4, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants