Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta 📆 iCal #2967

Open
6 of 15 tasks
JoeyStk opened this issue Aug 5, 2024 · 5 comments
Open
6 of 15 tasks

Meta 📆 iCal #2967

JoeyStk opened this issue Aug 5, 2024 · 5 comments
Labels
deadline Needs to be fixed in the given time feature New feature or request needs-internal-discussion Us developers need to discuss first which way of implementation is considered to be the best
Milestone

Comments

@JoeyStk JoeyStk added feature New feature or request blocked Blocked by external dependency needs-internal-discussion Us developers need to discuss first which way of implementation is considered to be the best labels Aug 5, 2024
@JoeyStk JoeyStk added this to the 24Q4 milestone Aug 5, 2024
@nassabay
Copy link

nassabay commented Sep 9, 2024

Test Externe Kalender
Test wurde im Testumgebung gemacht

  • Beim Feld: „Die Kategorie, der ein Event zugeordnet sein muss, um importiert zu werden (Leer lassen, um alle Veranstaltungen zu importieren)“ im CMS System, man kann nur eine Kategorie schreiben: z.B: Integreat. Falls Kommunen weitere Kategorien „TAGS“ nehmen, wird die Veranstaltung nicht importiert.
  • Beim Feld: „Die Kategorie, der ein Event zugeordnet sein muss, um importiert zu werden (Leer lassen, um alle Veranstaltungen zu importieren)“ im CMS System, wird zwischen große und kleine Buchstaben differenziert. Wenn Kommunen beim Kalender „Integreat“ schreiben und wir im CMS System „integreat“ schreiben, werden Veranstaltungen nicht importieren.
  • Hinweis: bei Apple kann man keine Kategorien vergeben. Ich glaube aber nicht dass eine Kommune mit Apple arbeitet.
  • Der Kalender von Saarburg hat keine Kategorien.
  • Wenn Kommunen Veranstaltungen importieren die mehr als 28 Tage dauern, werden wir bei uns ein Problem in unsere System sehen. Siehe „Bild 1. Veranstaltungsdauert.png“. Fehlerhafte Veranlagungen werden importiert. Beispiel: https://cms-test.integreat-app.de/saarburg-kell/external-calendars/
  • Im Kalendar von Saarburg: https://www.saarburg.de/?post_type=tribe_events&tribe-bar-date=2024-09-08&ical=1&eventDisplay=list es sind 30 Veranstaltungen im .ics zu finden; aber nur 27 werden importiert. Ich weißt nicht welche nicht importiert wurden, wäre eine Verbesserung ein Report zu bekommen falls etwas nicht funktioniert hat. Der sollte aber ein die Leute in der Kommune gehen, nicht nur bei uns.
  • Wenn Kommunen eine Veranstaltung bearbeiten, soll auch sie im CMS System aktualisiert werden, es ist unklar wie oft aktualisiert sich den Kalender mit Neuen Updates.
  • Ich habe die Veranstaltung „Integrationskonferenz“ in Kalender von 17.-20. September angelegt. In Integreat ist die von 17-bis 21. September zu sehen. Ich finden nicht den Fehler. Siehe Bild 2
    Bild 1  Veranstaltungsdauert
    Bild 2

@JoeyStk JoeyStk added deadline Needs to be fixed in the given time and removed blocked Blocked by external dependency labels Sep 12, 2024
@JoeyStk JoeyStk changed the title Improve on iCal [7.11.24] Improve on iCal Sep 12, 2024
@JoeyStk
Copy link
Contributor Author

JoeyStk commented Sep 23, 2024

  • Prefetch Existing Tags: If possible, it might be useful to fetch all tags once the domain is entered. This way, tags could be presented as a combobox instead of a text field, which could help prevent errors.
  • Import Error: There is an error occurring when importing events from Saarburg. The specific error is: Aug 01 08:46:13 ERROR integreat_cms.core.storages - An error occurred while importing events from this external calendar and Could not import 'Ausstellung Günter Schuster: Material und Sprache': The maximum duration for events is 28 days. Consider using recurring events if the event is not continuous.
  • Event Review: It would be helpful to have an overview of all imported and erroneous events after import and before storing them. This would facilitate a thorough review process.
  • Error Handling: The status column provides a detailed explanation of errors, but it's unclear how to handle them. Consider adding a popup for errors to provide more space if there are multiple issues.
  • Error Management: Adding a button to clear reviewed errors would be useful so that subsequent users do not have to deal with errors that have already been addressed. This would also aid in identifying new errors during cron job polling.

@nikolahoff
Copy link

@JoeyStk
Testing import iCal calendar:

  • importing the Saarland Kalender with the category "integreat" > positive feedback "all events were imported successfully" but the events were not in the list in the menu "Events" (screen 01 imported events: 0)
  • then I changed the category and left the field empty. An error occured. (screen 02)
  • But after reloading the page the status changed to imported events: 22 (screen 03)

For me the selection of the category is not understandable and clear what exactly it means. And the error messages don't align with what happens at the end.
screen 01 imported events
screen 02 error
screen 03 imported events

@juliankehne
Copy link

@JoeyStk

Tested in Testumgebung (24th Sep):

[Bug] Recurring events are not imported correctly:

  • Only the original event is shown in the Events page, marked as a One-Time event
  • All types of recurring events are affected, daily, weekly, etc.

[Bug] Events Marked as “All Day” (Ganztägig) end on a day after their scheduled date

  • Examples: a 2-day Event tagged as “All day” in .ics goes from 7th-8th in CMS it ends on 9th
  • a 1-day event tagged as “All day” ends on next day
  • iCalender format for Start and End Date when tagges as "All day" looks like this, which is probably why it displays it as ending on the next day in the CMS:
DTSTART;VALUE=DATE:20241104
DTEND;VALUE=DATE:20241105

[Bug] Importing Calender from nextcloud resulted in internal server error 500

[Bug] Delete prompt opens when pressing Enter

  1. In External Calendar Window
  2. Edit a calendar
  3. Select Any of the three text fields
  4. Press Enter
  5. “Delete Calendar Prompt” opens

[Bug] Trying to delete a calendar while it’s still loading events results in an Internal server error (500)

  • When deleting from the same tab or when another tab of the calendar is opened (while still loading all events)

"deleted account" set as creator of an event when checking the version history of an external calendar event
• Expected something like: “Imported from external calendar” or similar
2024-09-24 16_37_35-Integreat Editorial System — Mozilla Firefox

You can copy an event from an external calendar

  • The copied event is also part of the external calendar
  • The copied event is a draft, however is not editable since it is also part of the external calendar
  • You can still publish the draft when clicking (Show) behind the version number and then “Publish current draft” button
  • Update & Import Button in External Calendars deletes all events in a calender, including the copies made from the events
  • Deleting a calendar deletes also the events that were copied

None of the user roles (Autor:in, Redakteur:in, Terminplaner:in, Verwalter:in, Beobachter:in) can see the EXTERNAL CALENDAR column on the events page and wouldn't know that an event is from a calender unless they click on it.

Importing calendars with a lot of events (e.g. 100):

  • UX/UI No indication on how long it takes to import the calendar
  • Performance: calendars can take a long time 1+ minute to import

General feedback:

  • A calender with a lot of events would fill up the events list and there is no way to hide external calender events or filter for them specifically at the moment.
  • Events imported from a calendar are published instantly. It might be better to have them as a draft first and publish all events after checking that imported events are working as expected.
  • No information about which user imported a calendar and when it was imported
  • If a calender is automatically updated to refresh events then there is no indication for a user for when this happens or that it happens in the first place.
  • Error messages take up a lot of space when a calender has a lot of errors and could be more compact
  • Importing events with a specific category is case sensitive
    -- Example: Event in calendar is under category “Integreat”, putting in category “integreat” will not import the event with category “Integreat”.
  • Different calendar apps export .ics files differently. For example: Outlook (shared from browser version) does not include the categories. Nextcloud calendars do include categories. As mentioned in a comment above Apple doesn't even use categories in the first place.

@JoeyStk
Copy link
Contributor Author

JoeyStk commented Sep 30, 2024

  • Beim Feld: „Die Kategorie, der ein Event zugeordnet sein muss, um importiert zu werden (Leer lassen, um alle Veranstaltungen zu importieren)“ im CMS System, man kann nur eine Kategorie schreiben: z.B: Integreat. Falls Kommunen weitere Kategorien „TAGS“ nehmen, wird die Veranstaltung nicht importiert.

Not necessary for release on November 7th, but can be planned in for the future to make multiple tags easier to maintain. Work-around in the meantime: Create a second calendar with a second tag.

Beim Feld: „Die Kategorie, der ein Event zugeordnet sein muss, um importiert zu werden (Leer lassen, um alle Veranstaltungen zu importieren)“ im CMS System, wird zwischen große und kleine Buchstaben differenziert. Wenn Kommunen beim Kalender „Integreat“ schreiben und wir im CMS System „integreat“ schreiben, werden Veranstaltungen nicht importieren.

In the future we want to add the option to fetch all existing tags and put them into a dropdown to circumvent this kind of errors. Until then we will leave it as it is, because at the moment it only affects the Integreat staff

Hinweis: bei Apple kann man keine Kategorien vergeben. Ich glaube aber nicht dass eine Kommune mit Apple arbeitet.

Currently we don't know if categories will be used at all. For that we want to gather some experience with the municipalities, but will keep an eye on this.

Wenn Kommunen Veranstaltungen importieren die mehr als 28 Tage dauern, werden wir bei uns ein Problem in unsere System sehen. Siehe „Bild 1. Veranstaltungsdauert.png“. Fehlerhafte Veranlagungen werden importiert. Beispiel: https://cms-test.integreat-app.de/saarburg-kell/external-calendars/ &
Import Error: There is an error occurring when importing events from Saarburg. The specific error is: Aug 01 08:46:13 ERROR integreat_cms.core.storages - An error occurred while importing events from this external calendar and Could not import 'Ausstellung Günter Schuster: Material und Sprache': The maximum duration for events is 28 days. Consider using recurring events if the event is not continuous.

We hope that this will be fixed when working on #3070.

Im Kalendar von Saarburg: https://www.saarburg.de/?post_type=tribe_events&tribe-bar-date=2024-09-08&ical=1&eventDisplay=list es sind 30 Veranstaltungen im .ics zu finden; aber nur 27 werden importiert. Ich weißt nicht welche nicht importiert wurden, wäre eine Verbesserung ein Report zu bekommen falls etwas nicht funktioniert hat. Der sollte aber ein die Leute in der Kommune gehen, nicht nur bei uns.

As the most common error seems to be the duration limit we hope it will be solved by #3070. And if we encounter many other error messages in the future, we will think about this again.

Wenn Kommunen eine Veranstaltung bearbeiten, soll auch sie im CMS System aktualisiert werden, es ist unklar wie oft aktualisiert sich den Kalender mit Neuen Updates.

We will add the information on cronjob and manual imports in the wiki.

Ich habe die Veranstaltung „Integrationskonferenz“ in Kalender von 17.-20. September angelegt. In Integreat ist die von 17-bis 21. September zu sehen. Ich finden nicht den Fehler. Siehe Bild 2

  • We agree that this is a bug and want to fix it until November 7th.

Prefetch Existing Tags: If possible, it might be useful to fetch all tags once the domain is entered. This way, tags could be presented as a combobox instead of a text field, which could help prevent errors.

  • Good idea! We don't plan to finish this until November 7th, but will open up a follow-up issue for it.

Event Review & Error Handling & Error Management: It would be helpful to have an overview of all imported and erroneous events after import and before storing them. This would facilitate a thorough review process.

  • For now we keep it as it is and offer municipalities that want to see what the imported events look like to add them to the Testumgebung and show them. If many municipalities complain about this process, we will think about this is again.

You can still publish the draft when clicking (Show) behind the version number and then “Publish current draft” button

  • This is a bug and should be fixed.

Update & Import Button in External Calendars deletes all events in a calender, including the copies made from the events

  • Make the column "external calendar" in event list view visible for all user roles.
  • As a quick fix we want to disable the copy functionality for imported events
  • Long term: enable copying and allow to copy & convert events (fix also for deleting)

UX/UI No indication on how long it takes to import the calendar & Performance: calendars can take a long time 1+ minute to import

  • Will not be addressed until November 7th, but afterwards we want to make a few adjustments:
  • Don't import on the main thread
  • Show a message

A calender with a lot of events would fill up the events list and there is no way to hide external calender events or filter for them specifically at the moment.

  • Add a filter to events to filter for imported events & not imported events (After November 7th)

No information about which user imported a calendar and when it was imported

  • This is a bug and needs to be fixed

@JoeyStk JoeyStk changed the title [7.11.24] Improve on iCal Meta 📆 Improve on iCal Oct 4, 2024
@JoeyStk JoeyStk changed the title Meta 📆 Improve on iCal Meta 📆 iCal Oct 4, 2024
@osmers osmers modified the milestones: 24Q4, Meta Issues Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deadline Needs to be fixed in the given time feature New feature or request needs-internal-discussion Us developers need to discuss first which way of implementation is considered to be the best
Projects
None yet
Development

No branches or pull requests

5 participants