Optimize user, role and organizations SQL queries #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenseeberg
force-pushed
the
bugfix/user-performance
branch
6 times, most recently
from
4ee83a3
to
ffae7be
Compare
svenseeberg
changed the title
svenseeberg
force-pushed
the
bugfix/user-performance
branch
5 times, most recently
from
ca27c9b
to
114affc
Compare
svenseeberg
force-pushed
the
bugfix/user-performance
branch
2 times, most recently
from
256bd7c
to
82a8fa8
Compare
svenseeberg
force-pushed
the
bugfix/user-performance
branch
2 times, most recently
from
a70d1d5
to
f890ad4
Compare
melegiul
approved these changes
Sep 29, 2021
timobrembeck
approved these changes
Sep 29, 2021
There was a problem hiding this comment.
Prefetching the groups and role objects reduced the amount of queries even further: Instead of doing two additional queries for each user to retrieve the groups and the role of the user, this does now two queries in the beginning to get the groups and roles for all users at once, so a constant number of queries independently from the number of users in the database. 🎉
|
I'll rebase after the XLIFF PR is merged. |
|
The PR is merged, I guess you can rebase it now :) |
timobrembeck
force-pushed
the
bugfix/user-performance
branch
2 times, most recently
from
7df7b32
to
89ebfd7
Compare
- Select user organization along with user data. - Combine group and role queries into one to improve performance. - Prefetch group and role objects in user list Co-authored-by: Timo Ludwig <ludwig@integreat-app.de>
timobrembeck
force-pushed
the
bugfix/user-performance
branch
from
89ebfd7
to
899050a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at creating a checkbox at "users" in #943
Sadly, AFAICT there is not that much performance to gain here.