Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix page form change detection #1252

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Conversation

melegiul
Copy link
Contributor

Short description

Fix page form change detection

Proposed changes

Coerce initial and data value to integers
hasChanged

Resolved issues

Fixes: #1251

@melegiul melegiul requested a review from a team as a code owner February 28, 2022 08:59
@ulliholtgrave
Copy link
Member

Very good catch @melegiul ! 👍 Can you add a notice to the Changelog that the issue is solved? :)

@melegiul melegiul force-pushed the bugfix/page-form-change-detection branch from a5cb584 to 74837e9 Compare February 28, 2022 12:27
@melegiul
Copy link
Contributor Author

Thank you for your review, I have updated the changelog

CHANGELOG.md Outdated Show resolved Hide resolved
@melegiul melegiul force-pushed the bugfix/page-form-change-detection branch from 74837e9 to bbe3e55 Compare March 1, 2022 15:45
Copy link
Member

@timobrembeck timobrembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@melegiul melegiul merged commit c4e8825 into develop Mar 1, 2022
@melegiul melegiul deleted the bugfix/page-form-change-detection branch March 1, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unchanged page form
3 participants