Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete packages when cleaning a namespace via 'undeploy --all' #1319

Merged

Conversation

joshuaauerbachwatson
Copy link
Contributor

In PR #1297, the doctl sls undeploy command was re-implemented in pure golang. This change appears in release 1.85.0 and beyond.

There was an omission from the rewrite. After deleting all the functions of the namespace, the (now-empty) packages that contained some of those functions should also be deleted. This change restores that behavior.

This should not be considered a critical bug. As far as I know, no customer has complained about it. For the most part, the management of packages is done by the functions deployer in a transparent fashion (created on demand, used if present) and empty packages are not very likely to cause semantic problems. However,

  1. the contract to remove "all" resources from the namespace is violated unless we remove packages because packages are resources.
  2. There can sometimes be semantic problems from reusing packages if environment or parameter or annotation information has been attached to the package, so the omission is still worth fixing.

@andrewsomething andrewsomething merged commit 5a7b1cb into digitalocean:main Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants