-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement sls undeploy in native golang #1297
Implement sls undeploy in native golang #1297
Conversation
38b0bb4
to
97d256a
Compare
97d256a
to
dea884d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice job @ddebarros . With the exception of the substantive comment questioning the new --force
flag and prompt logic, my other comments are nits. The logic looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM!
Implements
doctl sls undeploy
subtree in goland instead of using the nim plugin.