Implement sls undeploy in native golang #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddebarros
force-pushed
the
undeploy-go-implementation
branch
from
38b0bb4
to
97d256a
Compare
ddebarros
force-pushed
the
undeploy-go-implementation
branch
from
97d256a
to
dea884d
Compare
There was a problem hiding this comment.
Very nice job @ddebarros . With the exception of the substantive comment questioning the new --force flag and prompt logic, my other comments are nits. The logic looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
doctl sls undeploysubtree in goland instead of using the nim plugin.