Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doks: Fix node-pool flags when creating cluster #391

Merged
merged 1 commit into from
Jan 13, 2019
Merged

doks: Fix node-pool flags when creating cluster #391

merged 1 commit into from
Jan 13, 2019

Conversation

bouk
Copy link
Contributor

@bouk bouk commented Jan 9, 2019

The check that verifies the count and size flags aren't passed in was wrong.

Fixes #389

@bouk bouk requested a review from aybabtme January 9, 2019 11:35
eddiezane
eddiezane approved these changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@eddiezane eddiezane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eddiezane eddiezane merged commit 2936f0c into master Jan 13, 2019
@eddiezane eddiezane deleted the count-size-flags branch January 13, 2019 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddiezane eddiezane eddiezane approved these changes

@aybabtme aybabtme Awaiting requested review from aybabtme

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bouk @eddiezane