Disable terminal ECHO flag when prompting for auth token #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@waynr Please rebase onto master and resubmit so it runs green so I can approve :) |
|
w/re the question of displaying the auth token when one is configured: I think it is a concern, as making it visible presents an issue when recording a session, for example. Would welcome a PR addressing that issue as well! |
waynr
force-pushed
the
disable-terminal-echo-during-auth-token-prompt
branch
from
371f471
to
cc09a51
Compare
Done!
Excellent, thanks for letting me know! I guess I forgot to actually file an issue to discuss the other day but it sounds like it's unnecessary anyway. |
|
Looking forward to the next PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes use of the
ReadPasswordfunction ingolang.org/x/crypto/ssh/terminalto avoid forcing the user to expose their auth token when entering it on the command line in response to thedoctl auth initprompt.This does not yet address the issue of printing the auth token when running
doctl auth initwhen one is already configured. I think I will file an issue to initiate discussion as to whether or not displaying the auth token is even a concern (I am accustomed to services like Github which more tightly control visibility of auth tokens).