Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure setting variable DIR before called on scripts/_build.sh #572

Merged
merged 1 commit into from
Sep 7, 2019
Merged

Make sure setting variable DIR before called on scripts/_build.sh #572

merged 1 commit into from
Sep 7, 2019

Conversation

nosada
Copy link
Contributor

@nosada nosada commented Sep 7, 2019

Fix error like below when invoking make native to build doctl executable:

$ make native
=> building doctl via go build

scripts/_build.sh: line 6: DIR: unbound variable
make: *** [Makefile:43: _build] Error 1

hilary
hilary approved these changes Sep 7, 2019
View reviewed changes
Copy link
Contributor

@hilary hilary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aargh! Thanks for the patch 😊

@hilary hilary merged commit 977c3d1 into digitalocean:master Sep 7, 2019
@nosada nosada deleted the fix-build-error-using-makefile branch September 8, 2019 02:04
@MattIPv4
Copy link
Member

MattIPv4 commented Sep 9, 2019

Hey, @nosada - Thanks a ton for this sweet PR! 😄

Would you please shoot me an email when you get a chance?
mcowley at digitalocean dot com 🎉

ejiektpobehuk pushed a commit to ejiektpobehuk/repo that referenced this pull request Apr 18, 2020
@nosada
Patch for _build.sh no longer needed because of digitalocean/doctl#572
e9f4687
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hilary hilary hilary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nosada @MattIPv4 @hilary