Allow operation to be blocking

[djsly]

https://github.com/terraform-providers/terraform-provider-digitalocean/issues/19

Has you can see, recently a change in the logic from the API at DO caused some issues with 3rd party app using the GODO product.

It would make sense that the GODO allow calls to be blocking, avoiding the different 3rd party app from doing polling and checking for statuses.

[mauricio]

Hey @djsly, can you elaborate on what's causing the issue here?

[djsly]

Hi @mauricio , sure, the issue started last week, where the deletion of the volume (storage) started returning 409. An error about the volume still being attached to a droplet.

So, even though we delete the droplet using the API, we get a 204 request, it was possible before to issue a deletion of the volume right away. Not we have to wait 3-4 sec for the droplet to be deleted for real on the DO side before the volume be we deleted properly.

It would be beneficial that all DELETION requests would return the 204 once and only once the deletion process is completed.
HTTP Status Code 204: The server has successfully fulfilled the request and that there is no additional content to send in the response payload body.

22:29 $ curl -X DELETE -H "Content-Type: application/json" -H "Authorization: Bearer <token>" "https://api.digitalocean.com/v2/droplets/53112244"

✔ ~ 
22:31 $ curl -X DELETE -H "Content-Type: application/json" -H "Authorization: Bearer <token>" "https://api.digitalocean.com/v2/volumes/938b3d10-5ade-11e7-91b8-0242ac116405"

{"id":"Illegal Action","message":"A volume that's attached to a Droplet cannot be deleted. Please detach it first before deleting."}✔ ~ 
22:31 $ 
✔ ~ 
22:31 $ 
✔ ~ 
22:31 $ curl -X DELETE -H "Content-Type: application/json" -H "Authorization: Bearer <token>" "https://api.digitalocean.com/v2/volumes/938b3d10-5ade-11e7-91b8-0242ac116405"
{"id":"Illegal Action","message":"A volume that's attached to a Droplet cannot be deleted. Please detach it first before deleting."}

✔ ~ 
22:31 $ curl -X DELETE -H "Content-Type: application/json" -H "Authorization: Bearer <token>" "https://api.digitalocean.com/v2/volumes/938b3d10-5ade-11e7-91b8-0242ac116405"
✔ ~

[mauricio]

@djsly fixed the issue himself at https://github.com/terraform-providers/terraform-provider-digitalocean/pull/22