Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible optimization? #7

Open
Nielsbishere opened this issue Dec 2, 2021 · 0 comments
Open

Possible optimization? #7

Nielsbishere opened this issue Dec 2, 2021 · 0 comments

Comments

@Nielsbishere
Copy link

Hi, this was a good read and interesting to see. One thing that might be interesting reading about is https://www.khronos.org/blog/vulkan-subgroup-tutorial, it basically allows to get rid of the atomicOr and barrier. Since you're executing 1 warp (32 threads), you can exchange it using subgroupOr (GL_KHR_shader_subgroup_arithmetic). Basically uint x = subgroupOr(result << gl_LocalInvocationIndex) in https://github.com/diharaw/HybridRendering/blob/master/src/shaders/ao/ao_ray_trace.comp#L120 and also the shadow pass from what I've read. I'm not sure if this is already done by the driver or compiler, but it might be interesting to check out anyways (if this wasn't done for reducing the extensions required to run the sample).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant