Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider name and version not parsed correctly when any part of version more than 1 digit #172

Closed
2 tasks
christi3k opened this issue Oct 22, 2019 · 1 comment · Fixed by #173
Closed
2 tasks

Comments

@christi3k
Copy link

Describe the bug

When installing the plugin with version information appended to the file per terraform documentation, the provider name and version are not parsed correctly when any part of the version suffix is more than one digit.

To Reproduce

Steps to reproduce the behavior:

  • macOS
  • terraform v0.12.12
  • openapi plugin v0.20.0
  1. wget https://github.com/dikhan/terraform-provider-openapi/releases/download/v0.20.0/terraform-provider-openapi_0.20.0_darwin_amd64.tar.gz
  2. tar -xzvf terraform-provider-openapi_0.20.0_darwin_amd64.tar.gz
  3. cp terraform-provider-openapi_v0.20.0 ~/.terraform.d/plugins/darwin_amd64/
  4. run TF_LOG=DEBUG terraform init and TF_LOG=DEBUG terraform plan with some terraform configuration that uses this provider.

In the logs for terraform plan, you should see something like this error:

[ERROR] There was an error when getting the provider's     name fomr the binary '/Users/chkoehle/.terraform.d/plugins/darwin_amd64/terraform-provider-slvm_v0.20.0': provider binary name (/Users/chkoehle/.           terraform.d/plugins/darwin_amd64/terraform-provider-slvm_v0.20.0) does not match terraform naming convention 'terraform-provider-{name}', please rename     the provider binary

Expected behaviour

No error to be reported during terraform plan.

Additional context

Checklist

Don't forget to go through the checklist to make sure the issue is created properly:

  • I have added a corresponding label (feature request/bug/etc) to the issue (right side menu)
  • I have added this issue to the 'API Terraform Provider' GitHub project (right side menu)
@dikhan
Copy link
Owner

dikhan commented Oct 22, 2019

Thanks @christi3k !

Just merged a fix for that. Will be releasing a new version shortly.

dikhan added a commit that referenced this issue Oct 23, 2019
- fixed: #172
- various refactoring
dikhan added a commit that referenced this issue Oct 23, 2019
- Feature #164: Migrate OpenAPI plugin terraform core imports to Terraform Plugin SDK
- Bug Fix #172: provider name and version not parsed correctly when any part of version more than 1 digit
devstar0826 added a commit to devstar0826/terraform-provider-openapi that referenced this issue Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants