Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support provider name with version containing multiple digits (e,g: terraform-provider-openapi_v0.20.0) #173

Merged
merged 2 commits into from
Oct 22, 2019

Conversation

dikhan
Copy link
Owner

@dikhan dikhan commented Oct 22, 2019

Enable multiple digits in regex that checks binary name and extracts the provider name

Proposed changes

Please add as many details as possible about the change here. Does this Pull Request resolve any open issue? If so, please make sure to link to that issue:

Fixes: #172

Type of change

What type of change does your code introduce to the provider? Please put an x (w/o heading/trailing white spaces)
in the boxes that apply:

  • Bug-fix (change that fixes current functionality)
  • New feature (change that adds new functionality)

Checklist

Please put an x (w/o heading/trailing white spaces) in the boxes that apply:

  • I have read and followed the CONTRIBUTING guidelines
  • I have made sure code compiles correctly
  • I have run 'make test' locally from the terraform_provider_api folder and no errors were found
  • I have added tests that prove my fix is effective or that my feature works
  • I have added/updated necessary documentation (if appropriate)

@dikhan dikhan added the bug label Oct 22, 2019
@codecov
Copy link

codecov bot commented Oct 22, 2019

Codecov Report

Merging #173 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #173      +/-   ##
==========================================
+ Coverage   88.89%   88.95%   +0.05%     
==========================================
  Files          51       51              
  Lines        3044     3042       -2     
==========================================
  Hits         2706     2706              
+ Misses        218      217       -1     
+ Partials      120      119       -1
Impacted Files Coverage Δ
main.go 24% <100%> (ø) ⬆️
tests/e2e/test_api_utils.go 62.96% <0%> (+2.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7e7c52...c92455d. Read the comment docs.

Copy link
Collaborator

@lillchan lillchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dikhan dikhan merged commit d177dc6 into master Oct 22, 2019
@dikhan dikhan deleted the bugfix/allow-multiple-digit-version branch October 22, 2019 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provider name and version not parsed correctly when any part of version more than 1 digit
2 participants