Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ns and NS-ns thresholds #13

Open
Carolina710 opened this issue Dec 1, 2020 · 2 comments
Open

ns and NS-ns thresholds #13

Carolina710 opened this issue Dec 1, 2020 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@Carolina710
Copy link

Hello Dmitry!

Thanks for the new commits! 👍

In the meantime, I found something that I think you know, but I would like to share.

For pixels that have few useful time samples, as you know, in Python they are treated with the condition:
image

From some results I obtained with Tile_1 data, I found some discrepancies in the results for magnitudes in Python vs OpenCL:
image
Where magnsPB is magnitudes in Python and magnsCLB is magnitudes in OpenCL, with a MSE (mean squared error) of 142647860.0.

This is the plot for the magnitudes <=0:
image

As we know, the algorithms are different so the results, but I managed to get some better results when I applied the same condition in OpenCL, after returning detailed results. Something like:
image

Namely, for this particular example, I like to use threshold 9 instead of 5. I obtained the results:
image

image
With a MSE of 0.30474687.

Do you think it is a good idea for the user to choose the value for the condition?

It's just an idea, not a big problem if we have good data to process.

Thank you!

@mortvest mortvest added bug Something isn't working enhancement New feature or request labels Dec 1, 2020
@mortvest
Copy link
Collaborator

Hello @Carolina710.
I am currently looking into this issue. Could you provide a dataset that you have used?

@Carolina710
Copy link
Author

Carolina710 commented Dec 26, 2020

Hello @mortvest the dataset used was "Tile_1": https://drive.google.com/drive/folders/15DK5T9hZUaaIBNsfzR3tTp5pFb9XCWt5?usp=sharing which I also shared in a previous issue.

Thank you, and happy holidays!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants