Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numpy should not be referenced in the setup.py #43

Open
12rambau opened this issue Feb 22, 2022 · 1 comment
Open

numpy should not be referenced in the setup.py #43

12rambau opened this issue Feb 22, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@12rambau
Copy link

it's it the same vein as #37.

I've corrected some of the bug in my own fork but i'm now seeing another issue. At line

bfast/setup.py

Line 132 in 4fd0c17

from numpy.distutils.core import setup
, the setup.py file is calling numpy. But there are 0 guarantee that numpy will be available when installing the lib.

This file should only rely on Python built-in modules like distutils or setuptools.

If not refactored, the lib cannot be installed as in :

pip install -r requirements.txt
@mortvest
Copy link
Collaborator

mortvest commented May 4, 2022

Yes, the setup script in general is a bit of a mess. It needs to be looked at.

@mortvest mortvest added the bug Something isn't working label May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants