Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming inconsistency in shape function derivatives #3

Closed
abhimadan opened this issue Apr 29, 2020 · 1 comment
Closed

Naming inconsistency in shape function derivatives #3

abhimadan opened this issue Apr 29, 2020 · 1 comment

Comments

@abhimadan
Copy link

In the *_dphi_dX functions, the output variable is named dX, but this same value is named dXinv in the *_dq2 and *_dq functions. I think this is true for both the main source files and the mex wrappers.

@dilevin
Copy link
Owner

dilevin commented May 4, 2020

I've renamed all these variables as dphidX because they are the gradients of the shape functions (phi) with respect to the reference element configuration (X).

@dilevin dilevin closed this as completed May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants