Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elm-graphql is still outputting Debug.toString when generating scalar debuggers. #68

Closed
obmarg opened this issue Aug 27, 2018 · 3 comments

Comments

@obmarg
Copy link

obmarg commented Aug 27, 2018

I'm trying to compile an app that uses elm-graphql 1.0.0 with elm 0.19 and --optimize but it's not compiling as some of my Api.Object.* modules have Debug.toString calls in them.

I see that 3720d8d was meant to swap these out for the 0.19 equivalents, but if I look in dist/bundle.js I can still see the old Debug.toString implementation. Has something gone wrong with the release?

@dillonkearns
Copy link
Owner

Hello @obmarg, thank you for filing the issue!

That commit was changing out the uses of toString internally, but you're absolutely right, we should also switch out uses in the generated code so that users can compile their code using Debug.toString. I'll work on a fix today and push it out ASAP. Thanks!

@dillonkearns
Copy link
Owner

Hello @obmarg, I've pushed a fix for this! You'll need to update to Elm package version 1.1.0 and NPM package version 1.0.1. Thanks again for reporting the issue!

@obmarg
Copy link
Author

obmarg commented Aug 29, 2018

Awesome, thanks for the rapid fix @dillonkearns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants