Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images missing max-width property #19

Closed
paskal opened this issue Dec 11, 2017 · 8 comments
Closed

Images missing max-width property #19

paskal opened this issue Dec 11, 2017 · 8 comments

Comments

@paskal
Copy link
Contributor

paskal commented Dec 11, 2017

Current behavior, main page and single post page:

current-main
current-single

Images have max-width set to 100%:

fixed-main
fixed-single

I don't think it's a feature, seems like a bug - could you please introduce this css property to make my pictures look nice again?;)

@dim0627
Copy link
Owner

dim0627 commented Dec 11, 2017

OK, I'll revert that merge commit temporary.

@dim0627
Copy link
Owner

dim0627 commented Dec 11, 2017

This is not related PR 🤔 ?
#20

I'll try reproduce tonight.
Please wait 🙏

@dim0627
Copy link
Owner

dim0627 commented Dec 11, 2017

@paskal
Do you use this code?

{{% img src="images/image.jpg" %}}

@paskal
Copy link
Contributor Author

paskal commented Dec 12, 2017

It's not related to #18. I use ![image description](image link), I am using pure markdown syntax to keep things simple, I've just migrated from other platform and it doesn't work the way it used to on other platform.

@dim0627
Copy link
Owner

dim0627 commented Dec 12, 2017

hmm, Okay.

I made commit just now.
fdc721b

Please try again.

@paskal
Copy link
Contributor Author

paskal commented Dec 12, 2017

It fixed single page but not main page with multiply articles. Seems like it's under body->ul->img on main page.
I guess you should drop every max-width redefinition for img per element which is equal to 100%, and set it globally - you don't want image to break any of the pages, are you?
And when you need lower (or higher) bound for it, then you redefine it on particular elements level (like .article-body).

@dim0627
Copy link
Owner

dim0627 commented Dec 12, 2017

fix it.

@dim0627 dim0627 closed this as completed Dec 12, 2017
@dim0627
Copy link
Owner

dim0627 commented Dec 12, 2017

7718359

This was referenced Mar 20, 2018
This was referenced Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants