Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style guide: add tables content #22892

Merged
merged 5 commits into from
Jan 7, 2019
Merged

Style guide: add tables content #22892

merged 5 commits into from
Jan 7, 2019

Conversation

orangejenny
Copy link
Contributor

@orangejenny orangejenny added the product/admin Change affects admin pages only visible to super users / staff label Jan 7, 2019
Copy link
Member

@biyeun biyeun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAAAAY!

<li>Use whitespace</li>
<li>
Keep small screens in mind, consider
<a href='https://css-tricks.com/rotated-table-column-headers/' target='_blank'>oblique headers</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we use this in HQ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. New suggestion from Meghan.

@orangejenny orangejenny merged commit 03c33da into master Jan 7, 2019
@orangejenny orangejenny deleted the jls/styleguide-tables branch January 7, 2019 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product/admin Change affects admin pages only visible to super users / staff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants