Fail hard on ES shard failure #23724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this seems to happen only very rarely anyways, but returning incomplete results seems worse in most cases than just getting an error
millerdev
approved these changes
Mar 21, 2019
corehq/elastic.py
Outdated
| @@ -536,3 +540,6 @@ def report_shard_failures(search_result): | |||
|
|
|||
| if search_result.get('_shards', {}).get('failed'): | |||
| datadog_counter('commcare.es.partial_results', value=1) | |||
| # Example message: | |||
| # "_shards: {'successful': 2, 'failed': 0, 'total': 2}" | |||
There was a problem hiding this comment.
nit: except the failed value should never be zero if we get here
corehq/elastic.py
Outdated
| @@ -536,3 +540,6 @@ def report_shard_failures(search_result): | |||
|
|
|||
| if search_result.get('_shards', {}).get('failed'): | |||
| datadog_counter('commcare.es.partial_results', value=1) | |||
| # Example message: | |||
| # "_shards: {'successful': 2, 'failed': 0, 'total': 2}" | |||
There was a problem hiding this comment.
I think this function (and docstring) is no longer well named as it now raises an exception.
Would it be useful to also include the query in the error message so we can figure out what happened? Or is that included in the stacktrace already?
There was a problem hiding this comment.
I think ES requests show up in the sentry breadcrumbs. I've confirmed that's the case for some ESError 500 sentry events, so I'm fairly sure about this
millerdev
approved these changes
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this seems to happen only very rarely anyways, but returning incomplete results seems
worse in most cases than just getting an error