add ability to archive forms submitted by a user #24384
Conversation
| def handle(self, domain, user_id, **options): | ||
| form_accessor = FormAccessors(domain) | ||
| form_ids = form_accessor.get_form_ids_for_user(user_id) | ||
| print("Found %s forms for user" % len(form_ids)) |
| if response == 'yes': | ||
| with open("archived_forms_for_user_%s.txt" % user_id, 'wb') as log: | ||
| for _ids in chunked(with_progress_bar(form_ids), 100): | ||
| _ids = list([_f for _f in _ids if _f]) |
There was a problem hiding this comment.
Curious why you're using underscore prefix on these variables? That's a convention used to mark a variable as private, but it's not necessary here since this is a local function scope and those names are not accessible outside of this function.
mkangia
force-pushed
the
mk-archive-form-by-user
branch
from
57c51af
to
7d9568d
Compare
There was a problem hiding this comment.
I assume you're skipping tests with [skip ci] because there are no tests for the code you added? This is generally got a good practice because, even though there are no new tests, it's possible that a change in this PR could cause existing tests to fail for some reason. It's true that a test failure caused by this PR is unlikely, but it's safer to allow tests to run and catch the issue early rather than assuming all is good and only finding out when other people's PRs start failing after this one gets merged into master.
|
@millerdev ya this was an isolated management command, not changing anything in the code base so i thought having a test run was not necessary. |
need for this task but thought of adding it as a management command for reuse if needed