Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation changes for code review location #29686

Merged
merged 1 commit into from
May 10, 2021

Conversation

ctsims
Copy link
Member

@ctsims ctsims commented May 7, 2021

Summary

Documentation only change.

Updates internal documentation to reflect the new structure of the contribution / PR docs

Safety Assurance

  • Risk label is set correctly
  • All migrations are backwards compatible and won't block deploy
  • The set of people pinged as reviewers is appropriate for the level of risk of the change
  • If QA is part of the safety story, the "Awaiting QA" label is used
  • I have confidence that this PR will not introduce a regression for the reasons below

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

@ctsims ctsims added the product/invisible Change has no end-user visible impact label May 7, 2021
@snopoke snopoke merged commit f02bf2c into master May 10, 2021
@snopoke snopoke deleted the ctsims/code_review_repo_restructure branch May 10, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product/invisible Change has no end-user visible impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants