Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Girth Effect Visualizer Uses Randomized Values on Each Adjustment #10

Closed
Lunix-420 opened this issue Jul 9, 2024 · 0 comments · Fixed by #20
Closed

Girth Effect Visualizer Uses Randomized Values on Each Adjustment #10

Lunix-420 opened this issue Jul 9, 2024 · 0 comments · Fixed by #20
Assignees
Labels
bug Something isn't working

Comments

@Lunix-420
Copy link
Collaborator

Lunix-420 commented Jul 9, 2024

Description:
The Girth effect mixes the value with a randomized value to add high frequencies. The current UI implementation uses the same function to graph the visualizer of the Girth effect. As a result, each slight adjustment rerolls the entire graphic because new values are rolled every time the slider gets touched. To provide a consistent visual representation, we should use a fixed seed when calculating the Girth effect for the UI representation.

Steps to Reproduce:

  1. Load Plasma in a compatible host.
  2. Adjust the Girth effect slider.
  3. Observe the visualizer of the Girth effect.

Expected Behavior:
The visual representation of the Girth effect should be consistent with each adjustment, using a fixed seed for the random values to ensure the graphic does not reroll entirely with every slight adjustment.

Actual Behavior:
The visual representation of the Girth effect rerolls and changes completely with each slight adjustment due to new random values being calculated.

Operating System:
This issue is reproducible on all operating systems (Windows, MacOS, and Linux).

Plugin Version:
1.2.0

Additional Notes:
Fixing this issue will enhance the user experience by providing a more stable and predictable visual feedback when adjusting the Girth effect. This is important for sound design as it allows users to better understand the impact of fine adjustments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant